Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Fix initialization of Storybook in Angular 16.1 #23598

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jul 25, 2023

Closes #23568

What I did

Fixed initialization of Storybook in Angular 16.1. An nx project was wrongly recognized, because @angular-eslint/schematics introduced a dependency on nx. I have removed the logic to identify a workspace being a nx workspace by evaluating nx as a dependency. Instead, we only rely on the existent of a nx.json file, since that should be enough to identify a workspace using nx or not in most of the cases.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic added bug angular patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Jul 25, 2023
@valentinpalkovic valentinpalkovic requested a review from yannbf as a code owner July 25, 2023 10:33
@valentinpalkovic valentinpalkovic self-assigned this Jul 25, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-initialization-of-storybook-in-angular-16.1 branch from 06e3194 to 48694d1 Compare July 25, 2023 10:38
@valentinpalkovic valentinpalkovic changed the title Fix initialization of Storybook in Angular 16.1 Angular: Fix initialization of Storybook in Angular 16.1 Jul 25, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me! I guess nx.json will always be present in Nx projects.

cc @mandarini

@valentinpalkovic valentinpalkovic merged commit 0aec101 into next Jul 25, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/fix-initialization-of-storybook-in-angular-16.1 branch July 25, 2023 12:09
@github-actions github-actions bot mentioned this pull request Jul 25, 2023
27 tasks
storybook-bot pushed a commit that referenced this pull request Jul 25, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
@github-actions github-actions bot mentioned this pull request Jul 25, 2023
33 tasks
storybook-bot pushed a commit that referenced this pull request Jul 25, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 25, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 25, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 25, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 25, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
30 tasks
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 27, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 27, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 27, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 28, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 28, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 28, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 31, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Jul 31, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 2, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 2, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 2, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 2, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 3, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
32 tasks
storybook-bot pushed a commit that referenced this pull request Aug 4, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 8, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
@kasperpeulen kasperpeulen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't install storybook with Angular v16.1.0
3 participants