Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Improve new Button component #23765

Merged
merged 3 commits into from
Aug 9, 2023
Merged

UI: Improve new Button component #23765

merged 3 commits into from
Aug 9, 2023

Conversation

cdedreuille
Copy link
Contributor

@cdedreuille cdedreuille commented Aug 9, 2023

What I did

After a couple of tests, we would like to bring some updates on the Button component to make it easier to work with Storybook including these changes:

  • Rename variants to solid, outline, ghost` to follow standard.
  • Create a new <IconButton /> component to simplify types and use.
  • Bring icons as props, removing the ability to add any icons and be able to control sizes if we want to.

How to test

  1. Run this branch locally and run Storybook UI with yarn storybook:ui
  2. Open Storybook in your browser
  3. Access the Button component
  4. Access the IconButton component

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@cdedreuille cdedreuille added ui maintenance User-facing maintenance tasks ci:normal patch:no labels Aug 9, 2023
@cdedreuille cdedreuille self-assigned this Aug 9, 2023
@cdedreuille cdedreuille marked this pull request as ready for review August 9, 2023 08:51
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasperpeulen kasperpeulen merged commit a4c6298 into next Aug 9, 2023
20 checks passed
@kasperpeulen kasperpeulen deleted the charles-improve-buttons branch August 9, 2023 09:20
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants