-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Improve look and feel of status UI in sidebar #24099
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
JReinhold,
cdedreuille and
tmeasday
as code owners
September 7, 2023 15:11
MichaelArestad
previously requested changes
Sep 7, 2023
ndelangen
added
patch:yes
Bugfix & documentation PR that need to be picked to main branch
bug
and removed
feature request
labels
Sep 13, 2023
38 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
…sidebar UI: Improve look and feel of status UI in sidebar (cherry picked from commit 9c49e16)
Merged
6 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
…sidebar UI: Improve look and feel of status UI in sidebar (cherry picked from commit 9c49e16)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
…sidebar UI: Improve look and feel of status UI in sidebar (cherry picked from commit 9c49e16)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
…sidebar UI: Improve look and feel of status UI in sidebar (cherry picked from commit 9c49e16)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
…sidebar UI: Improve look and feel of status UI in sidebar (cherry picked from commit 9c49e16)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
…sidebar UI: Improve look and feel of status UI in sidebar (cherry picked from commit 9c49e16)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
…sidebar UI: Improve look and feel of status UI in sidebar (cherry picked from commit 9c49e16)
github-actions
bot
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:normal
maintenance
User-facing maintenance tasks
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
ui
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I tweaked some UI look and feel based on @MichaelArestad's feedback
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Not needed
Documentation
Not needed
Checklist for Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>