NextJS: Add compatibility with nextjs 13.5
#24239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yann Braga <yannbf@gmail.com>
ndelangen
requested review from
valentinpalkovic,
kasperpeulen and
yannbf
as code owners
ndelangen
changed the title
13.5
ndelangen
added
bug
nextjs
ci:daily
yannbf
added
the
patch:yes
yannbf
reviewed
Sep 20, 2023
yannbf
reviewed
Sep 20, 2023
Co-authored-by: Yann Braga <yannbf@gmail.com>
yannbf
approved these changes
Sep 20, 2023
Merged
8 tasks
ndelangen
added a commit
that referenced
this pull request
Sep 20, 2023
…mpatibility NextJS: Add compatibility with nextjs `13.5` (cherry picked from commit 85b63e0)
ndelangen
added a commit
that referenced
this pull request
Sep 20, 2023
…mpatibility NextJS: Add compatibility with nextjs `13.5` (cherry picked from commit 85b63e0)
github-actions
bot
added
the
patch:done
38 tasks
1 task
|
Hi there, I am currently using nextjs 14 and I need to use storybook version 6 because of legacy issues. I faced this problem ERR! Error: Cannot find module 'next/dist/shared/lib/router-context' when i tried to use storybook-addon-next. Is there any recommendations? |
|
Hi @kebearry Sorry to hear that! Storybook 6 and 7 are not maintained anymore. Can you elaborate on why you can't upgrade to Storybook 8? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24234
What I did
I modified the webpack config creation code to add compatibility with nextjs 13.5
Files we need to alias got moved, and thus i created a mapping of nextjs version to files to map.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Expect things to work, storybook should start and show up correctly.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>