Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon-actions] Check result of getPropertyDescriptor for IE11 #2428

Merged
merged 4 commits into from
Dec 5, 2017
Merged

[addon-actions] Check result of getPropertyDescriptor for IE11 #2428

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af14977
Check result of getPropertyDescriptor for IE11
jgoz Dec 4, 2017
0e4c470
Merge branch 'master' into fix-actions-undefined-descriptor
Hypnosphi Dec 4, 2017
745026d
Allow IE11 to set function name
jgoz Dec 5, 2017
1813b89
Merge branch 'master' into fix-actions-undefined-descriptor
Hypnosphi Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion addons/actions/src/preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ export function action(name) {
});
};

// IE11 may return an undefined descriptor
const nameDescriptor = Object.getOwnPropertyDescriptor(handler, 'name');
// This condition is true in modern browsers that implement Function#name properly
const canConfigureName = Object.getOwnPropertyDescriptor(handler, 'name').configurable;
const canConfigureName = nameDescriptor && nameDescriptor.configurable;
Copy link
Member

@Hypnosphi Hypnosphi Dec 4, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also try !nameDescriptor || nameDescriptor.configurable. As far as I remember, IE11 had no problems with overriding function name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I tested this suggestion in IE11 and it worked. Pushed a new commit, please have a look.


if (canConfigureName && name && typeof name === 'string') {
Object.defineProperty(handler, 'name', { value: name });
Expand Down