Docs: Point to styling-webpack addon in styling docs #24348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaunEvening
added
documentation
patch:yes
ShaunEvening
changed the title
jonniebigodes
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
@integrayshaun thanks for taking the time to make the adjustments. Appreciate it 🙏 ! All is good on my end. Merge away when able.
kylegach
reviewed
Oct 2, 2023
docs/configure/styling-and-css.md
Outdated
| @@ -2,7 +2,7 @@ | |||
| title: 'Styling and CSS' | |||
| --- | |||
|
|
|||
| There are many ways to include CSS in a web application, and correspondingly there are many ways to include CSS in Storybook. Usually, it is best to try and replicate what your application does with styling in Storybook’s configuration. To make this easier, we recommend using [`@storybook/addon-styling`](https://github.com/storybookjs/addon-styling). | |||
| There are many ways to include CSS in a web application, and correspondingly there are many ways to include CSS in Storybook. Usually, it is best to try and replicate what your application does with styling in Storybook’s configuration. To make this easier, we recommend using [`@storybook/addon-styling-webpack`](https://storybook.js.org/addons/@storybook/addon-styling-webpack/). | |||
There was a problem hiding this comment.
Worth calling out the type of projects this should (or should not) be used with?
There was a problem hiding this comment.
Great call out! I've added a few lines about this.
Closed
6 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit abe0d61)
19 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit abe0d61)
storybook-bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit abe0d61)
storybook-bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit abe0d61)
This was referenced Oct 5, 2023
storybook-bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
(cherry picked from commit abe0d61)
24 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
(cherry picked from commit abe0d61)
JReinhold
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.