-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nextjs: Fix v13.5.x #24453
Merged
Merged
Nextjs: Fix v13.5.x #24453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
angular
build
Internal-facing build tooling & test updates
labels
Oct 12, 2023
valentinpalkovic
requested review from
yannbf,
ndelangen,
kasperpeulen,
JReinhold and
vanessayuenn
as code owners
October 12, 2023 09:54
valentinpalkovic
added
the
ci:daily
Run the CI jobs that normally run in the daily job.
label
Oct 12, 2023
valentinpalkovic
force-pushed
the
valentin/setup-sandboxes
branch
from
October 12, 2023 10:29
d8a20fe
to
11aeb97
Compare
valentinpalkovic
changed the title
Sandbox: Readd Angular prerelease sandbox
Sandbox: Add new sandboxes
Oct 12, 2023
JReinhold
reviewed
Oct 12, 2023
Sorry @JReinhold. This PR is still WIP. Converted it to draft |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
yannbf
reviewed
Oct 12, 2023
yannbf
reviewed
Oct 12, 2023
Co-authored-by: Yann Braga <yannbf@gmail.com>
yannbf
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for doing this
valentinpalkovic
force-pushed
the
valentin/setup-sandboxes
branch
from
October 12, 2023 15:39
5c9b6b8
to
c8ec3a6
Compare
7 tasks
1 task
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24364, #24304
What I did
Readded Angular 17 prerelease sandbox and added Next.js canary
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>