Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextjs: Fix v13.5.x #24453

Merged
merged 15 commits into from
Oct 12, 2023
Merged

Nextjs: Fix v13.5.x #24453

merged 15 commits into from
Oct 12, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Oct 12, 2023

Closes #24364, #24304

What I did

Readded Angular 17 prerelease sandbox and added Next.js canary

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic added angular build Internal-facing build tooling & test updates labels Oct 12, 2023
@valentinpalkovic valentinpalkovic self-assigned this Oct 12, 2023
@valentinpalkovic valentinpalkovic added the ci:daily Run the CI jobs that normally run in the daily job. label Oct 12, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/setup-sandboxes branch from d8a20fe to 11aeb97 Compare October 12, 2023 10:29
@valentinpalkovic valentinpalkovic changed the title Sandbox: Readd Angular prerelease sandbox Sandbox: Add new sandboxes Oct 12, 2023
@valentinpalkovic valentinpalkovic marked this pull request as draft October 12, 2023 12:12
@valentinpalkovic
Copy link
Contributor Author

Sorry @JReinhold. This PR is still WIP. Converted it to draft

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
next 13.5.4 network, filesystem, environment +24 2.13 GB vercel-release-bot

Co-authored-by: Yann Braga <yannbf@gmail.com>
@valentinpalkovic valentinpalkovic marked this pull request as ready for review October 12, 2023 14:58
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this

@valentinpalkovic valentinpalkovic force-pushed the valentin/setup-sandboxes branch from 5c9b6b8 to c8ec3a6 Compare October 12, 2023 15:39
@valentinpalkovic valentinpalkovic merged commit 6b2150c into next Oct 12, 2023
15 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/setup-sandboxes branch October 12, 2023 17:11
@github-actions github-actions bot mentioned this pull request Oct 12, 2023
7 tasks
@valentinpalkovic valentinpalkovic changed the title Sandbox: Add new sandboxes Nextjs: Fix v13.5.x Oct 13, 2023
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. nextjs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook does not work with "next": "13.5.2-canary.0"
3 participants