-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added type annotation to helpers, added ts declaration files for angu… #2459
Merged
alterx
merged 17 commits into
storybookjs:release/3.3
from
ralzinov:fix-angular-typings
Dec 22, 2017
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5cefa7c
Added type annotation to helpers, added ts declaration files for angu…
ralzinov a3a5aa7
Merge branch 'release/3.3' into fix-angular-typings
ralzinov 5d09eed
Merge branch 'release/3.3' into fix-angular-typings
ralzinov 57f3084
Merge branch 'release/3.3' into fix-angular-typings
ralzinov ce8544a
fix typing errors in tests
ralzinov c8b9016
Merge branch 'release/3.3' into fix-angular-typings
ralzinov 2ce7d89
Merge branch 'release/3.3' into fix-angular-typings
ralzinov 6a6027c
Merge branch 'release/3.3' into fix-angular-typings
ralzinov 804e6de
Merge branch 'release/3.3' into fix-angular-typings
ndelangen 2cd7306
Merge branch 'release/3.3' into fix-angular-typings
ndelangen 841f260
Merge branch 'release/3.3' into fix-angular-typings
ralzinov ab75f9a
Merge branch 'release/3.3' into fix-angular-typings
ralzinov edaee12
Merge branch 'release/3.3' into fix-angular-typings
ralzinov e003561
fixed conflicts, added annotation to merged files
ralzinov 4650309
Merge branch 'release/3.3' into fix-angular-typings
Hypnosphi 2a90437
Merge branch 'release/3.3' into fix-angular-typings
ndelangen 0df588b
added "moduleMetadata" property to IGetStory interface at index.d.ts
ralzinov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
declare module '@storybook/angular/demo' { | ||
export const Button: any; | ||
export const Welcome: any; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import {NgModuleMetadata } from './dist/client/preview/angular/types'; | ||
|
||
export interface IStorybookStory { | ||
name: string, | ||
render: () => any | ||
} | ||
|
||
export interface IStoribookSection { | ||
kind: string, | ||
stories: IStorybookStory[] | ||
} | ||
|
||
export type IGetStory = () => { | ||
props?: {[p: string]: any}; | ||
moduleMetadata?: {[p: string]: NgModuleMetadata}; | ||
component: any | ||
}; | ||
|
||
export interface IApi { | ||
kind: string; | ||
addDecorator: (decorator: any) => IApi; | ||
add: (storyName: string, getStory: IGetStory ) => IApi; | ||
} | ||
|
||
declare module '@storybook/angular' { | ||
export function storiesOf(kind: string, module: NodeModule): IApi; | ||
export function setAddon(addon: any): void; | ||
export function addDecorator(decorator: any): IApi; | ||
export function configure(loaders: () => NodeRequire, module: NodeModule): void; | ||
export function getStorybook(): IStoribookSection[]; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also have type definitions in the
@types/...
npm organisation.Should we move these here? Or add them there also?
Are these even the same type of definitions?
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find any typings for apps at https://microsoft.github.io/TypeSearch/, only for addons.
I think app and type definitioins for it should be in same package, at least written with typescript like angular. It's not the same typings.