Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack5: Add export-order-loader and remove babel-plugin-named-exports-order #24749

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Nov 7, 2023

Closes #24748

What I did

Removed babel-plugin-named-exports-order and added a new export-order-loader to @storybook/builder-webpack5 to make the AST transformation compiler independent

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a Webpack5-based sandbox
  2. Open a Story
  3. Analyze the compiled code of the Story. It should export a __namedExportsOrder field with the preserved Story order
    Bildschirmfoto 2023-11-07 um 14 57 47
    (The variable is also exported, but not visible on the screenshot)

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this Nov 7, 2023
@valentinpalkovic valentinpalkovic added feature request builder-webpack5 ci:daily Run the CI jobs that normally run in the daily job. labels Nov 7, 2023
@valentinpalkovic valentinpalkovic changed the title Add export-order-loader and remove babel-plugin-named-exports-order Webpack5: Add export-order-loader and remove babel-plugin-named-exports-order Nov 7, 2023
@valentinpalkovic valentinpalkovic marked this pull request as draft November 7, 2023 14:39
@valentinpalkovic valentinpalkovic marked this pull request as ready for review November 8, 2023 08:15
@valentinpalkovic valentinpalkovic force-pushed the valentin/create-export-order-webpack5-loader branch from d95ebaa to 6cc2b34 Compare November 8, 2023 11:25
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Potential typo squat ember-template-compiler 1.9.0-alpha

Next steps

What is a potential typo squat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore ember-template-compiler@1.9.0-alpha

@valentinpalkovic valentinpalkovic merged commit 992a820 into next Nov 8, 2023
107 of 108 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/create-export-order-webpack5-loader branch November 8, 2023 13:16
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder-webpack5 ci:daily Run the CI jobs that normally run in the daily job. feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite babel-plugin-named-exports-order as a webpack-loader
2 participants