Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Log benchmark task error #24825

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Build: Log benchmark task error #24825

merged 1 commit into from
Nov 13, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 13, 2023

Closes #

What I did

If the benchmark task errors, it will log a message to mention that is a benchmark error.

Before, it logged like this:

⬇️ Installing local dependencies
> yarn install
➤ YN0000: · Yarn 4.0.1
➤ YN0000: ┌ Resolution step
Test results written to /tmp/storybook/test-results/sandbox.xml
Error running task sandbox:
{
  "errno": -2,
  "code": "ENOENT",
  "syscall": "spawn /bin/sh",
  "path": "/bin/sh",
  "spawnargs": [
    "-c",
    "du -sb ."
  ],
  "cmd": "du -sb ."
}

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

No need.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added build Internal-facing build tooling & test updates ci:normal labels Nov 13, 2023
@shilman shilman merged commit 36b2baf into next Nov 13, 2023
60 of 61 checks passed
@shilman shilman deleted the yann/log-benchmark-error branch November 13, 2023 14:11
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Nov 13, 2023
storybook-bot pushed a commit that referenced this pull request Nov 13, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 13, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 13, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 14, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 14, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 14, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 14, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 14, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 15, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 15, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 15, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 15, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 15, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 16, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 16, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 16, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 16, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 16, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 17, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 20, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 21, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 21, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 22, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 22, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 22, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 22, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 22, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 22, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 22, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 22, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 22, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 22, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 22, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 23, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 24, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 24, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 24, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 24, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 24, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 24, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 27, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 27, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 27, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 27, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 28, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 28, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 28, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
storybook-bot pushed a commit that referenced this pull request Nov 28, 2023
Build: Log benchmark task error
(cherry picked from commit 36b2baf)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants