Test: Don't attach action to function mock if action was added already

[tmeasday]

What I did

Fix issue with action logging twice, as identified by @jonniebigodes. The problem was that argTypesRegexps were attaching actions + mocks, and then attachActionsToFunctionMocks was adding the action a second time, as the indication of an action was different:

• fn.isAction in the first case
• fn._actionAttached in the second.

I just changed it to check for both, but we should consider reconciling the two.

@kasperpeulen:

• I'm not sure if this is due to Test: Model loaders as before each and restore mocks properly #24948 or if the issue was already there when you first added the attachActionsToFunctionMocks code.
  • if it wasn't already there, my guess is attachActionsToFunctionMocks maybe ran first before as it was an argsEnhancer. Not sure.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>