Core: Maintenance changes for NextJS embedding #25086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To workaround vercel/next.js#57962 cc @ndelangen. Not sure we want to merge this but it gets us through the demo for now.
So we can use `composeStory` without depending on `renerToCanvas` and react dom etc
shilman
changed the title
3 tasks
tmeasday
reviewed
Dec 2, 2023
code/lib/preview-api/src/modules/store/csf/testing-utils/index.ts
Outdated
Show resolved
Hide resolved
shilman
changed the title
shilman
requested review from
valentinpalkovic,
kasperpeulen,
ndelangen,
yannbf and
JReinhold
as code owners
|
Self-merging @tmeasday |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
This PR cherry-picks (and modifies as appropriate) a handful of minor maintenance changes from #24447 so that the experimental framework can be extracted from the monorepo.
Those changes include:
--exact-portCLI optionPlus some minor bugfixes and workarounds.
How to test
This has been tested in CI:
nextjs-serverrepo at Changes to use SB@next instead of canary nextjs-server#6🦋 Canary release
This pull request has been released as version
0.0.0-pr-25086-sha-b3010f16. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-25086-sha-b3010f16shilman/enable-embedded-storybookb3010f161702262848)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25086