-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Update Angular cli templates #25152
Angular: Update Angular cli templates #25152
Conversation
@valentinpalkovic I didn't notice that PR, when I decided to make this one, but sure I can add those changes. The parts I don't have are that yours set each component as standalone. Is that what we want? It is ideally what should be done, but do we want the examples to be ideal or a mix of what is supported? |
I would say let’s switch them over to standalone completely. WDYT? |
I made the changes and removed a few other things that didn't seem necessary. Should the stories file names be changed to lowercase? I assume the uppercase is from matching the React files, but I don't think Angular apps typically have files with an uppercase name. |
Sure! :) |
Updated the filenames. I also removed the default exports, since I don't think I have actually seen an Angular project doing that, but I can change that back if not wanted. |
Should this be patched back to 7.6 @valentinpalkovic @Marklb ? |
Yes let's do it. |
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Angular: Update Angular cli templates (cherry picked from commit 986f86b)
Closes #22453
What I did
Fixed a few issues with the initial stories in an Angular project.
I left a mix of standalone and non-standalone, since Angular supports both, but I can change them to all standalone if we want.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
yarn task --task sandbox --start-from auto --template angular-cli/default-ts
The code was incorrect, but because of how Storybook generates the NgModule they happened to still work in a story. So, you can access the stories to make sure I didn't break them, but this is mainly just a correction of the code.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>