Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Pass jsConfig to SWC Loader and load config with defaults #25203

Merged

Conversation

valentinpalkovic
Copy link
Contributor

Closes #25175

What I did

Load jsConfig and pass it to SWC Loader and load Next.js config with defaults

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a Next.js 14 sandbox
  2. Go to the tsconfig.json and add the following config:
{
  "compilerOptions": {
    "jsxImportSource": "nativewind"
  }
}
  1. Storybook should complain that nativewind's jsx runtime cannot be found (sure, its not installed). The point is not to fix this issue, but to make sure that Storybook respects the jsxImportSource option and to pass it to Next.js' swc loader.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this Dec 12, 2023
@valentinpalkovic valentinpalkovic added bug patch:yes Bugfix & documentation PR that need to be picked to main branch nextjs ci:daily Run the CI jobs that normally run in the daily job. labels Dec 12, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-tsconfig-not-considered-for-nextjs branch 2 times, most recently from 10ce9f5 to a6a2146 Compare December 14, 2023 12:07
@valentinpalkovic valentinpalkovic marked this pull request as ready for review December 19, 2023 10:32
.circleci/config.yml Show resolved Hide resolved
code/frameworks/nextjs/src/utils.ts Show resolved Hide resolved
@valentinpalkovic valentinpalkovic removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 15, 2024
@vanessayuenn vanessayuenn added this to the 8.0-beta milestone Jan 15, 2024
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-tsconfig-not-considered-for-nextjs branch 2 times, most recently from 313a183 to 39660d6 Compare January 16, 2024 09:54
@valentinpalkovic valentinpalkovic merged commit ab3c990 into next Jan 16, 2024
15 of 18 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-tsconfig-not-considered-for-nextjs branch January 16, 2024 09:55
@github-actions github-actions bot mentioned this pull request Jan 17, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. nextjs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants