Addon-Docs: Upgrade to MDX3 #25303
Merged
Addon-Docs: Upgrade to MDX3 #25303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
requested review from
ndelangen,
JReinhold,
tmeasday and
shilman
as code owners
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
shilman
requested changes
Dec 26, 2023
yannbf
force-pushed
the
yann/upgrade-mdx
branch
2 times, most recently
from
0433348
to
353d4c7
Compare
yannbf
changed the title
| @@ -98,15 +98,14 @@ | |||
| "prep": "node --loader ../../../scripts/node_modules/esbuild-register/loader.js -r ../../../scripts/node_modules/esbuild-register/register.js ../../../scripts/prepare/bundle.ts" | |||
| }, | |||
| "dependencies": { | |||
| "@jest/transform": "^29.3.1", | |||
| "@mdx-js/react": "^2.1.5", | |||
| "@babel/core": "^7.12.3", | |||
There was a problem hiding this comment.
Do you have any substantial reason why not the latest version of @babel/core is used?
There was a problem hiding this comment.
This was just the version defined in mdx2-csf. The caret should resolve to the latest version though. I can upgrade as well.
code/lib/core-server/package.json
Outdated
| @@ -68,7 +68,7 @@ | |||
| "@storybook/core-events": "workspace:*", | |||
| "@storybook/csf": "^0.1.2", | |||
| "@storybook/csf-tools": "workspace:*", | |||
| "@storybook/docs-mdx": "^0.1.0", | |||
| "@storybook/docs-mdx": "0.1.1--canary.13.929b700.0", | |||
There was a problem hiding this comment.
Reminder to use a proper version here.
yannbf
force-pushed
the
yann/upgrade-mdx
branch
from
1f9d883
to
bd5ea14
Compare
yannbf
force-pushed
the
yann/upgrade-mdx
branch
from
7fc7140
to
a80c3d5
Compare
yannbf
commented
Dec 29, 2023
yannbf
commented
Dec 29, 2023
yannbf
added
ci:daily
shilman
reviewed
Dec 30, 2023
yannbf
added
ci:normal
and removed
ci:daily
shilman
approved these changes
Jan 3, 2024
yannbf
commented
Jan 3, 2024
yannbf
commented
Jan 3, 2024
ndelangen
reviewed
Jan 3, 2024
15 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25182
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
yarn task --task sandbox --start-from auto --template react-vite/default-tsDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-25303-sha-7c4e18ec. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-25303-sha-7c4e18ecyann/upgrade-mdx7c4e18ec1704199980)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25303