-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Add preset with experimental server API #25664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
Move CLI utilities to core-common
Core: Add preset with experimental server API
Jan 19, 2024
shilman
requested review from
ndelangen,
JReinhold,
tmeasday,
yannbf,
valentinpalkovic and
kasperpeulen
as code owners
January 19, 2024 11:21
shilman
force-pushed
the
shilman/remove-addon-api
branch
from
January 19, 2024 11:30
af72b82
to
642d34f
Compare
code/lib/core-common/src/js-package-manager/JsPackageManager.ts
Outdated
Show resolved
Hide resolved
code/lib/core-common/src/js-package-manager/JsPackageManager.ts
Outdated
Show resolved
Hide resolved
shilman
force-pushed
the
shilman/remove-addon-api
branch
from
January 19, 2024 11:33
642d34f
to
00f9feb
Compare
shilman
force-pushed
the
shilman/remove-addon-api
branch
from
January 19, 2024 15:00
38f30c1
to
8de69e2
Compare
shilman
force-pushed
the
shilman/remove-addon-api
branch
from
January 19, 2024 15:21
8de69e2
to
c9a33ec
Compare
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
Added a new core preset called
experimental_serverAPI
which currently contains a single method,removeAddon
, which can be used to run the equivalent ofstorybook remove
but from a Node API:This involved a very large refactor of code moving a bunch of code out of
@storybook/cli
and intocore-common
:Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Add the following to a sandbox as
.storybook/manager.tsx
, along with the snippet above to.storybook/main.ts
.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-25664-sha-900501bb
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-25664-sha-900501bb sandbox
or in an existing project withnpx storybook@0.0.0-pr-25664-sha-900501bb upgrade
.More information
0.0.0-pr-25664-sha-900501bb
shilman/remove-addon-api
900501bb
1705683001
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25664