Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use haul/bin/cli.js for cross-platform support #2577

Merged
merged 6 commits into from
Jan 3, 2018

Conversation

danielkcz
Copy link
Contributor

Issue: #2575

What I did

Changed path to Haul CLI instead of using .bin folder.

@codecov
Copy link

codecov bot commented Jan 2, 2018

Codecov Report

Merging #2577 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2577   +/-   ##
=======================================
  Coverage   32.65%   32.65%           
=======================================
  Files         398      398           
  Lines        8868     8868           
  Branches      959      958    -1     
=======================================
  Hits         2896     2896           
- Misses       5304     5309    +5     
+ Partials      668      663    -5
Impacted Files Coverage Δ
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/components/src/table/table.js 83.33% <0%> (ø) ⬆️
addons/actions/src/lib/util/prepareArguments.js 57.14% <0%> (ø) ⬆️
addons/info/src/components/types/Shape.js 68.62% <0%> (ø) ⬆️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
addons/knobs/src/angular/helpers.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495a762...3b36bc6. Read the comment docs.

@danielkcz
Copy link
Contributor Author

It's kinda shame that this is not getting more attention as it's a rather annoying bug. Every time I install something with Yarn I have manually change dist files to keep it working. Not sure about failing tests, apparently not related to this change.

@Hypnosphi Hypnosphi requested a review from danielduan January 2, 2018 16:06
@Hypnosphi
Copy link
Member

Hypnosphi commented Jan 2, 2018

Why the old path doesn't work? I should be a symlink to the new one

@danielkcz
Copy link
Contributor Author

Well, Windows and symlinks ... I would say a long story :)

Copy link
Member

@danielduan danielduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me if this is just a change from using the simlinked bin file to the actual one.

@Hypnosphi is the chromatic test on CircleCI broken?

@ndelangen
Copy link
Member

Merge when ready

@ndelangen ndelangen merged commit 1af4e8d into storybookjs:master Jan 3, 2018
@danielkcz danielkcz deleted the haul-xplatform branch January 3, 2018 19:41
@Hypnosphi Hypnosphi added bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 3, 2018
shilman pushed a commit that referenced this pull request Jan 7, 2018
Use haul/bin/cli.js for cross-platform support
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants