-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use haul/bin/cli.js for cross-platform support #2577
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2577 +/- ##
=======================================
Coverage 32.65% 32.65%
=======================================
Files 398 398
Lines 8868 8868
Branches 959 958 -1
=======================================
Hits 2896 2896
- Misses 5304 5309 +5
+ Partials 668 663 -5
Continue to review full report at Codecov.
|
It's kinda shame that this is not getting more attention as it's a rather annoying bug. Every time I install something with Yarn I have manually change dist files to keep it working. Not sure about failing tests, apparently not related to this change. |
Why the old path doesn't work? I should be a symlink to the new one |
Well, Windows and symlinks ... I would say a long story :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me if this is just a change from using the simlinked bin file to the actual one.
@Hypnosphi is the chromatic test on CircleCI broken?
Merge when ready |
Use haul/bin/cli.js for cross-platform support
Issue: #2575
What I did
Changed path to Haul CLI instead of using
.bin
folder.