Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert: "Angular: Reduce the warnings from ts-loader via stricter list of includes" #26208

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Revert: "Angular: Reduce the warnings from ts-loader via stricter list of includes" #26208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60c1184
Revert "Angular: Reduce the warnings from `ts-loader` via stricter li…
kasperpeulen Feb 27, 2024
40e0cea
Loosen tsconfig a bit for storybook
kasperpeulen Feb 27, 2024
2654582
Add template typechecking
kasperpeulen Feb 27, 2024
01d0f7f
Fix build sandboxes
kasperpeulen Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/lib/cli/templates/angular/application/template-csf/.storybook/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"resolveJsonModule": true
},
"exclude": ["../src/test.ts", "../src/**/*.spec.ts"],
"include": ["../src/**/*.stories.*", "./preview.ts"],
"include": ["../src/**/*", "./preview.ts"],
"files": ["./typings.d.ts"]
}
2 changes: 1 addition & 1 deletion code/lib/cli/templates/angular/library/template-csf/.storybook/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"resolveJsonModule": true
},
"exclude": ["../src/test.ts", "../src/**/*.spec.ts"],
"include": ["../src/**/*.stories.*", "./preview.ts"],
"include": ["../src/**/*", "./preview.ts"],
"files": ["./typings.d.ts"]
}
8 changes: 2 additions & 6 deletions scripts/tasks/sandbox-parts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,12 +596,8 @@ async function prepareAngularSandbox(cwd: string, templateName: string) {
tsConfigJson.compilerOptions.skipLibCheck = true;
tsConfigJson.compilerOptions.noImplicitAny = false;
tsConfigJson.compilerOptions.strict = false;
tsConfigJson.include = [
...tsConfigJson.include,
'../template-stories/**/*.stories.ts',
// This is necessary since template stories depend on globalThis.components, which Typescript can't look up automatically
'../src/stories/**/*',
];

tsConfigJson.include = [...tsConfigJson.include, '../template-stories/**/*.stories.ts'];

if (templateName === 'Angular CLI (Version 15)') {
tsConfigJson.compilerOptions.paths = {
Expand Down
Loading