Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add docs for vue3-vite framework #26221

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Feb 27, 2024

What I did

See title

Screenshot of docs page

Checklist for Contributors

Testing

Manual testing

  1. Follow the steps in the contributing instructions for this branch, framework-doc-vue3-vite

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kylegach kylegach added documentation ci:docs Run the CI jobs for documentation checks only. labels Feb 27, 2024
@kylegach kylegach self-assigned this Feb 27, 2024
docs/get-started/vue-vite.md Outdated Show resolved Hide resolved
docs/get-started/vue-vite.md Outdated Show resolved Hide resolved
docs/get-started/vue-vite.md Outdated Show resolved Hide resolved
docs/get-started/vue-vite.md Outdated Show resolved Hide resolved
docs/get-started/vue-vite.md Outdated Show resolved Hide resolved
docs/get-started/vue-vite.md Outdated Show resolved Hide resolved
docs/get-started/vue-vite.md Outdated Show resolved Hide resolved
docs/get-started/vue-vite.md Outdated Show resolved Hide resolved
docs/get-started/vue-vite.md Outdated Show resolved Hide resolved
@kylegach
Copy link
Contributor Author

kylegach commented Feb 28, 2024

@chakAs3 @larsrickert — Hello! This my attempt at officially documented what you added in #22285. You might notice that a lot of is copy/pasted from your excellent PR description. 🙂 But I'd appreciate your thoughts, anyway!

@kylegach kylegach requested a review from larsrickert February 28, 2024 21:30
@kylegach kylegach force-pushed the framework-doc-vue3-vite branch from 1c16330 to a43340d Compare February 28, 2024 21:31
@kylegach kylegach marked this pull request as ready for review February 29, 2024 16:54
@kylegach kylegach force-pushed the framework-doc-vue3-vite branch 2 times, most recently from 3ca621f to d43219c Compare March 5, 2024 20:14
kylegach and others added 8 commits March 6, 2024 13:49
Co-authored-by: Lars Rickert <dev@lars-rickert.de>
- Update URL & sidebar nav
- Improve snippets and update screenshots
- Clarify that `docgen` API is only available in SB 8+
- Remove no descriptions limitation from events
- Add limitations section
@kylegach kylegach force-pushed the framework-doc-vue3-vite branch from d43219c to b3696dc Compare March 6, 2024 20:49
@kylegach kylegach force-pushed the framework-doc-vue3-vite branch from b3696dc to 5c269f2 Compare March 6, 2024 20:59
Copy link

nx-cloud bot commented Mar 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5c269f2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen merged commit dc74337 into next Mar 7, 2024
17 checks passed
@kasperpeulen kasperpeulen deleted the framework-doc-vue3-vite branch March 7, 2024 14:17
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants