Updated documentation wrt ejs exclusion #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2633 +/- ##
=======================================
Coverage 32.65% 32.65%
=======================================
Files 398 398
Lines 8868 8868
Branches 942 950 +8
=======================================
Hits 2896 2896
+ Misses 5336 5313 -23
- Partials 636 659 +23
Continue to review full report at Codecov.
|
Hypnosphi
reviewed
Jan 3, 2018
| @@ -87,6 +87,8 @@ Storybook uses the config returned from the above function. So, try to edit the | |||
| - first loader in the module.loaders (Babel loader for JS) | |||
| - all existing plugins | |||
|
|
|||
| > If your custom webpack config uses a fallback `file-loader`, it is necessary to exclude the `.ejs` file extension. | |||
There was a problem hiding this comment.
I'd rather say, if your config uses some loader without explicitly specifying applicable extentions via test option
There was a problem hiding this comment.
Sure, makes sense. I updated the wording.
Hypnosphi
approved these changes
Jan 3, 2018
|
Thanks @aaronfullerton! |
Hypnosphi
added a commit
that referenced
this pull request
Feb 12, 2018
Updated documentation wrt ejs exclusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the documentation to indicate the need to exclude the
.ejsfile extension from webpack file loaders. #2615How to test
N/A