-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update multiple components guidance #26544
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 43b4f0f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
afff61e
to
dba4179
Compare
dba4179
to
c5e8825
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for fixing this!! 🙏 Left a few minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on, really appreciate it 🙏 ! I've left some items for you to look into when you have a moment so that we can get this in and published into the documentation.
This reverts commit dba4179.
- Remove guidance to reuse entire stories - Clarify other guidance
Co-authored-by: Michael Shilman <shilman@users.noreply.github.com> Co-authored-by: jonniebigodes <joaocontadesenvolvimento@gmail.com>
2b1b883
to
b8e46fe
Compare
…nents Docs: Update multiple components guidance (cherry picked from commit 6b773a6)
…nents Docs: Update multiple components guidance (cherry picked from commit 6b773a6)
…nents Docs: Update multiple components guidance (cherry picked from commit 6b773a6)
…nents Docs: Update multiple components guidance (cherry picked from commit 6b773a6)
…nents Docs: Update multiple components guidance (cherry picked from commit 6b773a6)
…nents Docs: Update multiple components guidance (cherry picked from commit 6b773a6)
…nents Docs: Update multiple components guidance (cherry picked from commit 6b773a6)
…nents Docs: Update multiple components guidance (cherry picked from commit 6b773a6)
…nents Docs: Update multiple components guidance (cherry picked from commit 6b773a6)
…nents Docs: Update multiple components guidance (cherry picked from commit 6b773a6)
…nents Docs: Update multiple components guidance (cherry picked from commit 6b773a6)
Closes #15954
What I did
Checklist for Contributors
Testing
Manual testing
update-docs-multiple-components
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>