Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update diff-link in addon migration guide (again) #26552

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Mar 18, 2024

What I did

Follow-up to #26231 and #25826 We recently made some additional changes in the addon-kit that our links to the diff-view should include.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@JReinhold JReinhold added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch ci:docs Run the CI jobs for documentation checks only. labels Mar 18, 2024
@JReinhold JReinhold self-assigned this Mar 18, 2024
@JReinhold JReinhold changed the title Docs: Update addon migration commit pointer to addon-kit Docs: Update diff-link in addon migration guide (again) Mar 18, 2024
Copy link

nx-cloud bot commented Mar 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 811789a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JReinhold JReinhold merged commit af79778 into next Mar 18, 2024
18 of 26 checks passed
@JReinhold JReinhold deleted the jeppe/update-addon-migration-commit branch March 18, 2024 11:52
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
15 tasks
storybook-bot pushed a commit that referenced this pull request Mar 19, 2024
…on-commit

Docs: Update diff-link in addon migration guide (again)
(cherry picked from commit af79778)
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
11 tasks
storybook-bot pushed a commit that referenced this pull request Mar 19, 2024
…on-commit

Docs: Update diff-link in addon migration guide (again)
(cherry picked from commit af79778)
storybook-bot pushed a commit that referenced this pull request Mar 19, 2024
…on-commit

Docs: Update diff-link in addon migration guide (again)
(cherry picked from commit af79778)
storybook-bot pushed a commit that referenced this pull request Mar 19, 2024
…on-commit

Docs: Update diff-link in addon migration guide (again)
(cherry picked from commit af79778)
storybook-bot pushed a commit that referenced this pull request Mar 19, 2024
…on-commit

Docs: Update diff-link in addon migration guide (again)
(cherry picked from commit af79778)
storybook-bot pushed a commit that referenced this pull request Mar 19, 2024
…on-commit

Docs: Update diff-link in addon migration guide (again)
(cherry picked from commit af79778)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants