-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom tsconfig.json for angular apps. #2669
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fb930ed
Add ability to load a custom tsconfig.json in the storybook config dir.
igor-dv 1395110
Use extended loader syntax for ts loader in webpack.config.prod.js
igor-dv 9a9ddad
Add test for ts_config
igor-dv 2b9ddaa
Merge branch 'master' into custom-ts-config
igor-dv c68264d
Merge branch 'master' into custom-ts-config
igor-dv 842ff0b
Merge branch 'master' into custom-ts-config
igor-dv f98a55e
Merge branch 'master' into custom-ts-config
igor-dv bb79199
Merge branch 'master' into custom-ts-config
igor-dv cd40276
Merge branch 'master' into custom-ts-config
igor-dv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import fs from 'fs'; | ||
import path from 'path'; | ||
|
||
// avoid ESLint errors | ||
const logger = console; | ||
|
||
function resolveTsConfig(tsConfigPath) { | ||
if (!fs.existsSync(tsConfigPath)) { | ||
return null; | ||
} | ||
|
||
logger.info('=> Found custom tsconfig.json'); | ||
|
||
return tsConfigPath; | ||
} | ||
|
||
export default function(configDir) { | ||
const configFile = resolveTsConfig(path.resolve(configDir, 'tsconfig.json')); | ||
|
||
if (!configFile) { | ||
return {}; | ||
} | ||
|
||
return { | ||
configFile, | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import loadTsConfig from './ts_config'; | ||
|
||
// eslint-disable-next-line global-require | ||
jest.mock('fs', () => require('../../../../__mocks__/fs')); | ||
jest.mock('path', () => ({ | ||
resolve: () => 'tsconfig.json', | ||
})); | ||
|
||
const setupFiles = files => { | ||
// eslint-disable-next-line no-underscore-dangle, global-require | ||
require('fs').__setMockFiles(files); | ||
}; | ||
|
||
describe('ts_config', () => { | ||
it('should return the config with the path to the tsconfig.json', () => { | ||
setupFiles({ 'tsconfig.json': '{}' }); | ||
|
||
const config = loadTsConfig('.foo'); | ||
|
||
expect(config).toEqual({ | ||
configFile: 'tsconfig.json', | ||
}); | ||
}); | ||
|
||
it('should return empty object when there is no tsconfig.json', () => { | ||
setupFiles({}); | ||
|
||
const config = loadTsConfig('.foo'); | ||
|
||
expect(config).toEqual({}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"extends": "../tsconfig.json", | ||
"exclude": [ | ||
"../src/test.ts", | ||
"../src/**/*.spec.ts" | ||
], | ||
"include": [ | ||
"../src/**/*" | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if it looks ugly, IMO need some work moving webpack configurations to the core.