Change ng stories dir

[Quramy]

Issue:

See #2645

What I did

• Change generated stories directory location.

How to test

Is this testable with jest or storyshots?

[igor-dv]

@Quramy, can you take a look why are the cli test failing ? Looks like something is misconfigured with tsconfig.

[Quramy]

@igor-dv. As you said, this error is caused by src/tsconfig.json(I think src/tsconfig.json fails to configure typeRoots 🤔 ).

And the latest @angualr/cli generates not src/tsconfig.json but src/tsconfig.app.json, and using the latest generated tsconfig solves this error. So I'll update the fixture.

[codecov]

Codecov Report

Merging #2672 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2672   +/-   ##
=======================================
  Coverage   34.35%   34.35%           
=======================================
  Files         390      390           
  Lines        8772     8772           
  Branches      907      908    +1     
=======================================
  Hits         3014     3014           
+ Misses       5166     5136   -30     
- Partials      592      622   +30

Impacted Files	Coverage Δ
app/vue/src/server/utils.js	0% <0%> (-53.58%)	⬇️
...s/actions/src/lib/types/function/createFunction.js	53.33% <0%> (ø)	⬆️
addons/knobs/src/components/PropForm.js	9.3% <0%> (ø)	⬆️
.../ui/src/modules/ui/components/layout/dimensions.js	15.62% <0%> (ø)	⬆️
addons/knobs/src/components/types/Array.js	34.14% <0%> (ø)	⬆️
addons/knobs/src/react/WrapStory.js	49.42% <0%> (ø)	⬆️
app/react/src/demo/Welcome.js	64.7% <0%> (ø)	⬆️
app/react-native/src/bin/storybook-start.js	0% <0%> (ø)	⬆️
addons/a11y/src/components/Report/index.js	0% <0%> (ø)	⬆️
addons/a11y/src/components/Tabs.js	0% <0%> (ø)	⬆️
... and 61 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8b989...a5e0307. Read the comment docs.

[igor-dv]

LGTM.
@Hypnosphi any insights?

[Hypnosphi]

So I'll update the fixture.

Does it mean that this change will break people's apps that were initially bootstrapped with previous versions of @angular/cli?

[Quramy]

@Hypnosphi

Does it mean that this change will break people's apps that were initially bootstrapped with previous versions of @angular/cli?

The @angular/cli change related it is angular/angular-cli#4924, and this PR merged on Feb 23, 2017 and is before @angular/cli v1.0.0. So I think we don't have to worry. How about it ?

[igor-dv]

So is it good to go?

[alterx]

I think we're good to go if the change was made pre v1 and we support v1+

Have we tested this?

cc @igor-dv @Quramy

[Hypnosphi]

I'll change the base branch for a moment, just to check if it fixes issues with #2712