-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Add --no-dev
option to init
#26918
CLI: Add --no-dev
option to init
#26918
Conversation
e2f661e
to
c3e3ab9
Compare
--dev
and --no-dev
options to storybook init
CLI
--dev
and --no-dev
options to storybook init
CLI--dev
and --no-dev
options to storybook init
CLI
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d1a3474. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@fastfrwrd Thank you so much for your contribution.
--dev
and --no-dev
options to storybook init
CLI--no-dev
option to init
CLI: Add optional `--dev` and `--no-dev` options to `storybook init` CLI (cherry picked from commit e60fc12)
Closes #25510
What I did
adds optional
--dev
and--no-dev
options to thestorybook init
CLI.init
CLI to force the init workflow to conclude before running the dev server after initialization.storybook init
is run in CI or in the Storybook sandbox, although the option can also be used to override the behavior in those cases as well.true
, and I couldn't override the default value from the negated--no-dev
option, I was forced to add a--dev
option with the correct defaults. see --no is bugged with default arguments tj/commander.js#2068 (comment) and Adding negative option makes Commander.js to return "true" when option is not specified tj/commander.js#979 for more on this topic.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
as far as I could tell, there aren't automated tests for the
init
CLI?Manual testing
Ran the sandbox as described. Additionally, I ran the following against a fresh
create-next-app
to test that the flag works as expected, that the default behaviors still worked as expected, and that the intersection of the defaults and the flags also worked.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>