-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scss for components in angular apps by default. #2703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #2703 +/- ##
=======================================
Coverage 34.36% 34.36%
=======================================
Files 390 390
Lines 8771 8771
Branches 922 892 -30
=======================================
Hits 3014 3014
- Misses 5124 5165 +41
+ Partials 633 592 -41
Continue to review full report at Codecov.
|
Is it a breaking change? It loaded |
@Hypnosphi - I believe its just for |
loader: 'raw-loader', | ||
exclude: /\.async\.(html|css)$/, | ||
exclude: /\.async\.css$/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to exclude a css file is it doesn't pass the test
anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, I think I need to exclude html here.
This PR changes |
@Hypnosphi, it feels like a breaking change, but I prefer to look at it as a bug fix. Before, in order to make css work, people needed to extend webpack.config + exclude thigngs from css rules (because css didn't really work by default) + add scss. So now they maybe will need just to remove these extended webpack.config ... |
OK then |
Issue: #2688
Looks like most of the people (I don't know if it's most, but that what I've seen recently) prefer using scss instead of css.
What I did
Changed the raw-loader to use scss
For components that use
styleUrls
- scss will be loaded with a raw-loaderFor global imports - there will be still style-loader as before.