Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPC: Core Package Consolidation #27039

Merged
merged 365 commits into from
Jul 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
365 commits
Select commit Hold shift + click to select a range
c5290fa
remove tempy useage, because it's underlaying lib: temp-dir uses top-…
ndelangen Jun 3, 2024
bd1a212
change test to use core package
ndelangen Jun 3, 2024
8b48039
redirect imports
ndelangen Jun 3, 2024
0dd63f6
redirect imports
ndelangen Jun 3, 2024
a53f8e3
upgrade express
ndelangen Jun 3, 2024
dd039c8
add node install step (should be using nvmrc)
ndelangen Jun 3, 2024
e63f636
change circle config
ndelangen Jun 3, 2024
0aa14e2
Merge branch 'next' into norbert/cpc
ndelangen Jun 3, 2024
df0f14a
move manager-api
ndelangen Jun 3, 2024
7b0b333
fix
ndelangen Jun 3, 2024
98165f0
move preview
ndelangen Jun 3, 2024
8301aac
fixes
ndelangen Jun 3, 2024
9d67e56
fixes
ndelangen Jun 3, 2024
644721e
fixes
ndelangen Jun 3, 2024
a9070a8
fixes
ndelangen Jun 3, 2024
a5486e6
fix
ndelangen Jun 3, 2024
654c606
fixes
ndelangen Jun 3, 2024
436b3db
fixes
ndelangen Jun 3, 2024
325d7bb
fix
ndelangen Jun 3, 2024
c240f55
isolate sb/test package
ndelangen Jun 4, 2024
d002240
hack for sb/test package
ndelangen Jun 4, 2024
d3616d9
move sb/test
ndelangen Jun 4, 2024
ff91517
improve
ndelangen Jun 4, 2024
bc6bd59
move ui/components
ndelangen Jun 4, 2024
e977c2e
fixes
ndelangen Jun 4, 2024
dad097c
fixes
ndelangen Jun 4, 2024
553bb2b
improve
ndelangen Jun 4, 2024
3542fae
fix
ndelangen Jun 4, 2024
9f4648d
fix
ndelangen Jun 4, 2024
559d57f
fixes
ndelangen Jun 4, 2024
df86c22
fix
ndelangen Jun 5, 2024
7265e2f
fix
ndelangen Jun 5, 2024
7bfb034
Merge branch 'next' into norbert/cpc
ndelangen Jun 5, 2024
fa216bd
fixes
ndelangen Jun 5, 2024
e2057b8
fix
ndelangen Jun 5, 2024
cc20d49
fixes
ndelangen Jun 5, 2024
79e7ab7
fixes
ndelangen Jun 5, 2024
4a93f7f
fix
ndelangen Jun 5, 2024
a8134a4
sort
ndelangen Jun 5, 2024
5c08752
Merge branch 'next' into norbert/cpc
ndelangen Jun 5, 2024
0aaa35f
fix
ndelangen Jun 5, 2024
6f2e316
fix order of export maps
ndelangen Jun 5, 2024
9b65392
fixes
ndelangen Jun 5, 2024
e108739
Merge branch 'next' into norbert/cpc
ndelangen Jun 5, 2024
0a4522a
add retry
ndelangen Jun 5, 2024
1cfa32f
fix
ndelangen Jun 5, 2024
64cc3a9
fix
ndelangen Jun 5, 2024
383c01e
use core for tests
ndelangen Jun 5, 2024
773cdbb
move fonts
ndelangen Jun 5, 2024
3e38e70
move ui/manager
ndelangen Jun 6, 2024
c26eea8
cleanup
ndelangen Jun 6, 2024
50ce5c1
fixes
ndelangen Jun 6, 2024
c4e814d
fix
ndelangen Jun 6, 2024
998bff4
fixes
ndelangen Jun 6, 2024
59efad1
fix
ndelangen Jun 6, 2024
7e678e9
Merge branch 'next' into norbert/cpc
ndelangen Jun 6, 2024
022fe08
improve
ndelangen Jun 6, 2024
fbd4ac1
improve
ndelangen Jun 6, 2024
6acaea4
add interactions stories, because why not?
ndelangen Jun 6, 2024
17bb499
fix type issues by ignoring them... this is how it was before... but …
ndelangen Jun 6, 2024
d711b81
fixes
ndelangen Jun 6, 2024
d742884
fixes
ndelangen Jun 6, 2024
588924f
Merge branch 'next' into norbert/cpc
ndelangen Jun 6, 2024
6df6afa
fix
ndelangen Jun 6, 2024
8294029
fix
ndelangen Jun 6, 2024
5add5e5
improve
ndelangen Jun 6, 2024
806e176
ignore this story, as it needs a special decorator for storybookAPI
ndelangen Jun 7, 2024
1c2a20f
fix
ndelangen Jun 7, 2024
790c5c6
move manager builder templates
ndelangen Jun 7, 2024
616ae92
move builder-manager
ndelangen Jun 7, 2024
005a37b
lint scripts
ndelangen Jun 7, 2024
5132bc1
fixes
ndelangen Jun 7, 2024
d3adbbc
fix
ndelangen Jun 7, 2024
fd909fe
fix
ndelangen Jun 7, 2024
49d0882
Merge branch 'next' into norbert/cpc
ndelangen Jun 7, 2024
a85462f
fix
ndelangen Jun 7, 2024
6247c5f
fix
ndelangen Jun 7, 2024
b7f8950
move core-server
ndelangen Jun 7, 2024
8b418a5
fix
ndelangen Jun 7, 2024
c7b73f1
fixes
ndelangen Jun 7, 2024
4412b1c
Merge branch 'next' into norbert/cpc
ndelangen Jun 7, 2024
5d8a467
fixes
ndelangen Jun 7, 2024
d1c47b4
fix
ndelangen Jun 7, 2024
0373aca
add higher size limit to verdaccio
ndelangen Jun 7, 2024
7fa53ee
fixes
ndelangen Jun 7, 2024
c59fe8a
externalize ws
ndelangen Jun 7, 2024
5384244
fix
ndelangen Jun 8, 2024
0c01551
bring back test and instrumenter
ndelangen Jun 8, 2024
3299028
fix
ndelangen Jun 8, 2024
73e679d
fix
ndelangen Jun 8, 2024
5119a91
fix
ndelangen Jun 8, 2024
3d84f45
fixes
ndelangen Jun 8, 2024
a897f58
fixes
ndelangen Jun 8, 2024
3e09e18
fixes
ndelangen Jun 8, 2024
034551c
fixes
ndelangen Jun 8, 2024
914cc76
fixes
ndelangen Jun 8, 2024
e09c0eb
fix
ndelangen Jun 9, 2024
0b0a2b6
Merge branch 'next' into norbert/cpc
ndelangen Jun 9, 2024
4dbbf9d
move
ndelangen Jun 9, 2024
d924d14
fix
ndelangen Jun 9, 2024
72ff559
fix
ndelangen Jun 9, 2024
248e1a1
bump orb version
ndelangen Jun 9, 2024
8c81126
Merge branch 'next' into norbert/cpc
ndelangen Jun 10, 2024
a7e6767
make peerDep a broad version range
ndelangen Jun 10, 2024
c6e00fc
fix lockfiles
ndelangen Jun 10, 2024
b1c4ea5
upgrade yarn & sync
ndelangen Jun 10, 2024
78c6f5f
remove unused deps that gave peerDep warnings
ndelangen Jun 10, 2024
c84daf1
remove corepack packageManager fields
ndelangen Jun 10, 2024
e625ef9
add explainer
ndelangen Jun 10, 2024
108cd97
undo the upgrade to test-storybook yarn versions
ndelangen Jun 10, 2024
0fbc97c
add yarn version back
ndelangen Jun 10, 2024
095d03a
fix
ndelangen Jun 10, 2024
74cfb9c
fix
ndelangen Jun 10, 2024
9bf5336
Merge branch 'next' into norbert/cpc
ndelangen Jun 10, 2024
7ecba7c
ensure mapper files are always generated first
ndelangen Jun 10, 2024
d06e361
improve
ndelangen Jun 10, 2024
5ac129b
fix for windows, hopefully with a single retry
ndelangen Jun 10, 2024
aa0e744
cleanup
ndelangen Jun 10, 2024
d7ed2dc
Merge branch 'next' into norbert/cpc
ndelangen Jun 11, 2024
576a2e1
fix
ndelangen Jun 11, 2024
09a88d0
Merge branch 'next' into norbert/cpc
ndelangen Jun 12, 2024
e388a0e
Merge branch 'next' into norbert/cpc
ndelangen Jun 12, 2024
75ed6e8
fix
ndelangen Jun 12, 2024
3c9c9f5
revert
ndelangen Jun 12, 2024
931d63d
Merge branch 'next' into norbert/cpc
ndelangen Jun 12, 2024
69eb6b8
Merge branch 'next' into norbert/cpc
ndelangen Jun 18, 2024
64dd532
fix
ndelangen Jun 18, 2024
6263439
Merge branch 'next' into norbert/cpc
ndelangen Jun 19, 2024
e35b884
drop the `/dist` part
ndelangen Jun 19, 2024
c53be0a
fix
ndelangen Jun 19, 2024
8505d86
migrate core to use the non-dist path
ndelangen Jun 19, 2024
ac31f4b
get rid of the last bits referencing core/dist
ndelangen Jun 19, 2024
e09e9b4
final cleanup
ndelangen Jun 19, 2024
525a98b
make the `storybook` package portal to `@storybook/core`
ndelangen Jun 21, 2024
8e2db19
make packages peerDep on `storybook` package instead of `@storybook/c…
ndelangen Jun 21, 2024
cb5b778
make packages peerDep on `storybook` package instead of `@storybook/c…
ndelangen Jun 21, 2024
c6f9289
tried migrating the cli package to type-module to try to get vite to …
ndelangen Jun 21, 2024
7c8cc56
change references from `@storybook/cli` to `storybook`
ndelangen Jun 22, 2024
2ff0087
fix a few unit tests due to the cli now being type:module
ndelangen Jun 22, 2024
f56ef2b
fix linting
ndelangen Jun 22, 2024
2d76a5f
proxy all including `storybook` package
ndelangen Jun 22, 2024
a452400
fix
ndelangen Jun 22, 2024
a18a63f
force close after publishing with --open
ndelangen Jun 22, 2024
4193511
fix script to generate portal to core
ndelangen Jun 22, 2024
40407a6
fix a type issue
ndelangen Jun 23, 2024
e40e275
trial and error
ndelangen Jun 23, 2024
ca0047a
fix mapping to core-events errors
ndelangen Jun 24, 2024
84f2398
trying to make it work
ndelangen Jun 24, 2024
147f78d
fixes
ndelangen Jun 24, 2024
47b3a3f
fixes
ndelangen Jun 24, 2024
6d7e1b3
add cjs files to cli package.json declaration
yannbf Jun 24, 2024
8dcd2f8
Merge branch 'norbert/cpc-storybook' of github.com:storybookjs/storyb…
yannbf Jun 24, 2024
caecadb
fix
yannbf Jun 24, 2024
127c8a5
chore: Remove commented out code in entries.ts
ndelangen Jun 24, 2024
c415320
disable test
ndelangen Jun 24, 2024
eb760b7
Update import paths for core files in update-core-portal.ts
ndelangen Jun 24, 2024
4e2aa1c
cleanup
ndelangen Jun 24, 2024
99e27a2
Merge branch 'next' into norbert/cpc
ndelangen Jun 24, 2024
389b7e7
don't need type generation for unit tests AFAIK
ndelangen Jun 24, 2024
c68d8cd
bump the lockfile
ndelangen Jun 24, 2024
949f878
cleanup
ndelangen Jun 24, 2024
699011e
fix
ndelangen Jun 24, 2024
986d090
chore: update path import to use node:path module
ndelangen Jun 24, 2024
b9b5982
fix test
ndelangen Jun 24, 2024
7c22d90
fix test
ndelangen Jun 24, 2024
05f306e
remove embedding of components into blocks
ndelangen Jun 24, 2024
532d251
disable this test
ndelangen Jun 24, 2024
47972ff
chore: Update path import to use node:path module
ndelangen Jun 25, 2024
fa5caa7
chore: Remove unused imports in entries.ts
ndelangen Jun 25, 2024
c1a42e0
cleanup
ndelangen Jun 25, 2024
d813d6c
Merge branch 'norbert/cpc' into norbert/cpc-storybook
ndelangen Jun 25, 2024
dca9ede
Merge pull request #28310 from storybookjs/norbert/cpc-storybook
ndelangen Jun 25, 2024
1f0f923
Add `alias`s for possibly missing `peerDeps` for `addon-docs`
ndelangen Jun 25, 2024
58ccf51
Add `alias`s for possibly missing `peerDeps` for `addon-docs`, for we…
ndelangen Jun 25, 2024
c5b7b6c
resolve common-manager
ndelangen Jun 25, 2024
b18a416
fix
ndelangen Jun 25, 2024
868bbcf
make @storybook/core an exact dep version range
ndelangen Jun 25, 2024
3c14455
Merge branch 'next' into norbert/cpc
ndelangen Jun 25, 2024
bff2b04
remove unused variable
ndelangen Jun 25, 2024
da9856d
fixing chalk
ndelangen Jun 25, 2024
7bcbcd2
cleanup
ndelangen Jun 25, 2024
3a13dd9
cleanup the `ui` dir
ndelangen Jun 25, 2024
990b252
fix
ndelangen Jun 25, 2024
34c3825
fix
ndelangen Jun 25, 2024
6c55b9e
fixes
ndelangen Jun 25, 2024
2affd31
fix
ndelangen Jun 25, 2024
1885b55
fix
ndelangen Jun 25, 2024
ce79687
chore: Update chromatic.config.json and package.json
ndelangen Jun 25, 2024
3604614
cleanup
ndelangen Jun 25, 2024
aa66843
Remove unused "Blocks Only" Storybook
JReinhold Jun 25, 2024
c9e78f0
fixes
ndelangen Jun 25, 2024
52e8e1f
Merge pull request #28346 from storybookjs/norbert/cpc-cleanup
ndelangen Jun 25, 2024
b255698
delete unused facade
ndelangen Jun 25, 2024
48b270c
add README for core
ndelangen Jun 26, 2024
a1c112a
IMprove the CLI README.md
ndelangen Jun 26, 2024
c694c50
additions to CONTRIBUTING.md
ndelangen Jun 26, 2024
0370ab3
Merge branch 'next' into norbert/cpc
ndelangen Jun 26, 2024
b927c1b
hopefully fix tests on windows
yannbf Jun 26, 2024
b38dc62
Merge branch 'norbert/cpc' of https://github.com/storybookjs/storyboo…
yannbf Jun 26, 2024
a8fe212
fix tests
yannbf Jun 26, 2024
cf0d3f8
fix linting
ndelangen Jun 26, 2024
c5a75ba
fix linting issues
ndelangen Jun 26, 2024
4b7f268
fix linting
ndelangen Jun 26, 2024
8147701
Merge branch 'next' into norbert/cpc
ndelangen Jun 26, 2024
f7889a8
cleanup the paths to `./dist` in cli & core
ndelangen Jun 26, 2024
8281b79
cleanup and make code modular
ndelangen Jun 26, 2024
95605d9
tiny fix to the mapping for build script
ndelangen Jun 26, 2024
65814b9
Merge branch 'norbert/cpc' into norbert/cpc-no-dist-in-core-exports
ndelangen Jun 26, 2024
c6a79d5
Merge branch 'next' into norbert/cpc
ndelangen Jun 26, 2024
6b32316
hard code the verdaccio URl without proxy
ndelangen Jun 26, 2024
34d820e
hard code URl to publish to
ndelangen Jun 26, 2024
9dccd65
Merge branch 'next' into norbert/cpc
ndelangen Jun 27, 2024
17bf89f
improve type safety of Button.tsx
ndelangen Jun 27, 2024
d0fd233
improve type safety of ActionBar.tsx
ndelangen Jun 27, 2024
e7b0508
cleanup
ndelangen Jun 27, 2024
ee440d3
cleanup
ndelangen Jun 27, 2024
bbc9c9a
chore: Refactor TabsState initial prop assignment using nullish coale…
ndelangen Jun 27, 2024
5822daa
cleanup
ndelangen Jun 27, 2024
9f14be5
fixing the doctor command
ndelangen Jun 27, 2024
df82a58
Add documentation of what the purpose of `update-core-portal`.ts` is.
ndelangen Jun 27, 2024
ccc1ef9
Merge branch 'next' into norbert/cpc
ndelangen Jun 27, 2024
0ccbdad
cleanup
ndelangen Jun 27, 2024
47ddb31
Refactor SVG animation in remount.tsx to use undefined instead of 'un…
ndelangen Jun 27, 2024
8cdb768
remove use of yarn branch version
ndelangen Jun 27, 2024
3d37114
Add explainer for the need of the proxy server in front of verdaccio
ndelangen Jun 27, 2024
8ea8b9e
undo renaming in a docs page
ndelangen Jun 27, 2024
c225b59
remove @storybook/test as a peerDep from addon-actions
ndelangen Jun 27, 2024
f888e91
Merge branch 'next' into norbert/cpc
ndelangen Jun 27, 2024
20b815f
chore: Remove @storybook/test as a peerDep from addon-actions
ndelangen Jun 27, 2024
54138f1
Explain the aliases for @storybook/addon-docs & @storybook/blocks in …
ndelangen Jun 27, 2024
9846f26
adding the deps for instrumenter back for addon-interaction
ndelangen Jun 27, 2024
652ed9d
Merge branch 'next' into norbert/cpc
ndelangen Jun 28, 2024
fc1d713
Merge branch 'norbert/remove-unused-2' into norbert/cpc
ndelangen Jun 28, 2024
ae80878
improve/fix type generation in prod mode
ndelangen Jun 28, 2024
dce41a3
no longer output
ndelangen Jun 28, 2024
ea54a16
never have .tsx files as entries for core, as it causes inconsistent …
ndelangen Jun 28, 2024
06c5a27
fix package.json
ndelangen Jun 28, 2024
c071d1b
Merge branch 'next' into norbert/cpc
ndelangen Jun 28, 2024
0838803
improve variable names
ndelangen Jun 28, 2024
3e9d8bc
generate `storybook/internal/x` in `storybook`'s `package.json`
ndelangen Jun 28, 2024
3a1e61c
add an `/internal` in the path to core subpaths from `storybook`
ndelangen Jun 28, 2024
170e509
add more `/internal` paths
ndelangen Jun 28, 2024
4f7bc5c
Merge branch 'next' into norbert/cpc
ndelangen Jun 28, 2024
0a3f1bd
sync version
ndelangen Jun 28, 2024
106339e
fix linting
ndelangen Jun 28, 2024
8f256ae
fix
ndelangen Jun 28, 2024
b5f6c2d
Merge branch 'next' into norbert/cpc
ndelangen Jun 28, 2024
f8466d4
remove packageManager field
ndelangen Jun 28, 2024
fbc1196
fix
ndelangen Jun 28, 2024
1aec38d
Merge branch 'next' into norbert/cpc
ndelangen Jul 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
27 changes: 18 additions & 9 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ orbs:
browser-tools: circleci/browser-tools@1.4.1
discord: antonioned/discord@0.1.0
codecov: codecov/codecov@3.2.4
bun-orb: cmgriffing/bun-orb@0.0.29
node: circleci/node@5.2.0
nx: nrwl/nx@1.6.2

commands:
Expand Down Expand Up @@ -129,6 +131,8 @@ jobs:
steps:
- git-shallow-clone/checkout_advanced:
clone_options: "--depth 1 --verbose"
- bun-orb/setup:
version: 1.1.1
- restore_cache:
name: Restore Yarn cache
keys:
Expand Down Expand Up @@ -161,6 +165,7 @@ jobs:
- code/frameworks
- code/deprecated
- code/lib
- code/core
- code/builders
- code/ui
- code/renderers
Expand Down Expand Up @@ -189,6 +194,8 @@ jobs:
steps:
- git-shallow-clone/checkout_advanced:
clone_options: "--depth 1 --verbose"
- bun-orb/setup:
version: 1.1.1
- attach_workspace:
at: .
- nx/set-shas:
Expand Down Expand Up @@ -260,7 +267,7 @@ jobs:
at: .
- codecov/upload
- report-workflow-on-failure
chromatic-internal-storybooks:
chromatic-internal-storybook:
executor:
class: medium+
name: sb_node_18_browsers
Expand All @@ -273,10 +280,8 @@ jobs:
at: .
- run:
name: Running Chromatic
command: |
cd code
yarn storybook:ui:chromatic
yarn storybook:blocks:chromatic
command: yarn storybook:ui:chromatic
working_directory: code
- report-workflow-on-failure
- store_test_results:
path: test-results
Expand Down Expand Up @@ -339,6 +344,8 @@ jobs:
steps:
- git-shallow-clone/checkout_advanced:
clone_options: "--depth 1 --verbose"
- bun-orb/setup:
version: 1.1.1
- attach_workspace:
at: .
- run:
Expand All @@ -349,13 +356,15 @@ jobs:
- run:
name: Building Sandboxes
command: yarn task --task build --template $(yarn get-template --cadence << pipeline.parameters.workflow >> --task build) --no-link --start-from=never --junit
environment:
STORYBOOK_TELEMETRY_URL: "http://localhost:6007/event-log"
- run:
name: Verifying Telemetry
command: |
TEMPLATE=$(yarn get-template --cadence << pipeline.parameters.workflow >> --task build)
if [[ $TEMPLATE != bench/* ]]
then
node --loader esbuild-register/loader -r esbuild-register ./event-log-checker build $TEMPLATE
node --loader esbuild-register/loader -r esbuild-register ./event-log-checker.ts build $TEMPLATE
fi
working_directory: scripts
- report-workflow-on-failure:
Expand Down Expand Up @@ -644,7 +653,7 @@ workflows:
- script-checks:
requires:
- build
- chromatic-internal-storybooks:
- chromatic-internal-storybook:
requires:
- build
- coverage:
Expand Down Expand Up @@ -706,7 +715,7 @@ workflows:
- script-checks:
requires:
- build
- chromatic-internal-storybooks:
- chromatic-internal-storybook:
requires:
- build
- coverage:
Expand Down Expand Up @@ -769,7 +778,7 @@ workflows:
- script-checks:
requires:
- build
- chromatic-internal-storybooks:
- chromatic-internal-storybook:
requires:
- build
- create-sandboxes:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/canary-release-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:

| | |
| --- | --- |
| **Published version** | [`${{ steps.version.outputs.next-version }}`](https://npmjs.com/package/@storybook/cli/v/${{ steps.version.outputs.next-version }}) |
| **Published version** | [`${{ steps.version.outputs.next-version }}`](https://npmjs.com/package/storybook/v/${{ steps.version.outputs.next-version }}) |
| **Triggered by** | @${{ github.triggering_actor }} |
| **Repository** | [${{ steps.info.outputs.repository }}](https://github.com/${{ steps.info.outputs.repository }}) |
| **Branch** | [`${{ steps.info.outputs.branch }}`](https://github.com/${{ steps.info.outputs.repository }}/tree/${{ steps.info.outputs.branch }}) |
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/generate-sandboxes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ jobs:
with:
ref: next

- uses: oven-sh/setup-bun@v1
with:
bun-version: 1.1.1

- uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"
Expand Down Expand Up @@ -82,6 +86,10 @@ jobs:
with:
ref: main

- uses: oven-sh/setup-bun@v1
with:
bun-version: 1.1.1

- uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/prepare-non-patch-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ jobs:
with:
node-version-file: ".nvmrc"

- uses: oven-sh/setup-bun@v1
with:
bun-version: 1.1.1

- name: Cache dependencies
uses: actions/cache@v4
with:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/prepare-patch-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ jobs:
with:
node-version-file: ".nvmrc"

- uses: oven-sh/setup-bun@v1
with:
bun-version: 1.1.1

- name: Cache dependencies
uses: actions/cache@v4
with:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ jobs:
with:
node-version-file: ".nvmrc"

- uses: oven-sh/setup-bun@v1
with:
bun-version: 1.1.1

- name: Cache dependencies
uses: actions/cache@v4
with:
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/tests-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,15 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: oven-sh/setup-bun@v1
with:
bun-version: 1.1.1
- name: Set node version
uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"

- name: install and compile
run: yarn task --task compile --start-from=auto --no-link
run: yarn task --task compile --start-from=auto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we run tests in no-link mode on CI to have the most realistic experience?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit tests are not affected by this at all.

This saves about 2 minutes of CI time.

- name: test
run: yarn test
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,5 @@ code/playwright/.cache/
code/bench-results/

/packs
code/.nx/cache
code/.nx/cache
!**/fixtures/**/yarn.lock
12 changes: 10 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

Storybook is developed against a specific node version which is defined in an `.nvmrc` file. You can use any Node version manager that uses the `.nvmrc` configuration file (we recommend [fnm](https://fnm.vercel.app/)).

## Ensure you have the required system utilities

You will need to have the following installed:
- git
- node
- yarn
- (bun)[https://bun.sh/]

## Using fnm as a Node version manager

- Install fnm [as per instructions](https://github.com/Schniz/fnm/tree/master#installation)
Expand Down Expand Up @@ -50,7 +58,7 @@ If you want to make code changes to Storybook packages while running a sandbox,

```bash
cd code
yarn build --watch react core-server api addon-docs
yarn build --watch react core addon-docs
```

2. If you are running the sandbox in "linked" mode (the default), you should see the changes reflected on a refresh (you may need to restart it if changing server packages)
Expand All @@ -71,7 +79,7 @@ yarn task --prod

```bash
cd code
yarn build --prod --watch angular core-server api addon-docs
yarn build --prod --watch angular core addon-docs
```

## Contributing to Storybook
Expand Down
26 changes: 13 additions & 13 deletions MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,17 +100,17 @@
- [Tab addons cannot manually route, Tool addons can filter their visibility via tabId](#tab-addons-cannot-manually-route-tool-addons-can-filter-their-visibility-via-tabid)
- [Removed `config` preset](#removed-config-preset-1)
- [From version 7.5.0 to 7.6.0](#from-version-750-to-760)
- [CommonJS with Vite is deprecated](#commonjs-with-vite-is-deprecated)
- [Using implicit actions during rendering is deprecated](#using-implicit-actions-during-rendering-is-deprecated)
- [typescript.skipBabel deprecated](#typescriptskipbabel-deprecated)
- [Primary doc block accepts of prop](#primary-doc-block-accepts-of-prop)
- [Addons no longer need a peer dependency on React](#addons-no-longer-need-a-peer-dependency-on-react)
- [CommonJS with Vite is deprecated](#commonjs-with-vite-is-deprecated)
- [Using implicit actions during rendering is deprecated](#using-implicit-actions-during-rendering-is-deprecated)
- [typescript.skipBabel deprecated](#typescriptskipbabel-deprecated)
- [Primary doc block accepts of prop](#primary-doc-block-accepts-of-prop)
- [Addons no longer need a peer dependency on React](#addons-no-longer-need-a-peer-dependency-on-react)
- [From version 7.4.0 to 7.5.0](#from-version-740-to-750)
- [`storyStoreV6` and `storiesOf` is deprecated](#storystorev6-and-storiesof-is-deprecated)
- [`storyIndexers` is replaced with `experimental_indexers`](#storyindexers-is-replaced-with-experimental_indexers)
- [`storyStoreV6` and `storiesOf` is deprecated](#storystorev6-and-storiesof-is-deprecated)
- [`storyIndexers` is replaced with `experimental_indexers`](#storyindexers-is-replaced-with-experimental_indexers)
- [From version 7.0.0 to 7.2.0](#from-version-700-to-720)
- [Addon API is more type-strict](#addon-api-is-more-type-strict)
- [Addon-controls hideNoControlsWarning parameter is deprecated](#addon-controls-hidenocontrolswarning-parameter-is-deprecated)
- [Addon API is more type-strict](#addon-api-is-more-type-strict)
- [Addon-controls hideNoControlsWarning parameter is deprecated](#addon-controls-hidenocontrolswarning-parameter-is-deprecated)
- [From version 6.5.x to 7.0.0](#from-version-65x-to-700)
- [7.0 breaking changes](#70-breaking-changes)
- [Dropped support for Node 15 and below](#dropped-support-for-node-15-and-below)
Expand All @@ -136,7 +136,7 @@
- [Deploying build artifacts](#deploying-build-artifacts)
- [Dropped support for file URLs](#dropped-support-for-file-urls)
- [Serving with nginx](#serving-with-nginx)
- [Ignore story files from node_modules](#ignore-story-files-from-node_modules)
- [Ignore story files from node\_modules](#ignore-story-files-from-node_modules)
- [7.0 Core changes](#70-core-changes)
- [7.0 feature flags removed](#70-feature-flags-removed)
- [Story context is prepared before for supporting fine grained updates](#story-context-is-prepared-before-for-supporting-fine-grained-updates)
Expand All @@ -150,7 +150,7 @@
- [Addon-interactions: Interactions debugger is now default](#addon-interactions-interactions-debugger-is-now-default)
- [7.0 Vite changes](#70-vite-changes)
- [Vite builder uses Vite config automatically](#vite-builder-uses-vite-config-automatically)
- [Vite cache moved to node_modules/.cache/.vite-storybook](#vite-cache-moved-to-node_modulescachevite-storybook)
- [Vite cache moved to node\_modules/.cache/.vite-storybook](#vite-cache-moved-to-node_modulescachevite-storybook)
- [7.0 Webpack changes](#70-webpack-changes)
- [Webpack4 support discontinued](#webpack4-support-discontinued)
- [Babel mode v7 exclusively](#babel-mode-v7-exclusively)
Expand Down Expand Up @@ -200,7 +200,7 @@
- [Dropped addon-docs manual babel configuration](#dropped-addon-docs-manual-babel-configuration)
- [Dropped addon-docs manual configuration](#dropped-addon-docs-manual-configuration)
- [Autoplay in docs](#autoplay-in-docs)
- [Removed STORYBOOK_REACT_CLASSES global](#removed-storybook_react_classes-global)
- [Removed STORYBOOK\_REACT\_CLASSES global](#removed-storybook_react_classes-global)
- [7.0 Deprecations and default changes](#70-deprecations-and-default-changes)
- [storyStoreV7 enabled by default](#storystorev7-enabled-by-default)
- [`Story` type deprecated](#story-type-deprecated)
Expand Down Expand Up @@ -5616,7 +5616,7 @@ Also, here's the error you'll get if you're running an older version of React:
```

core.browser.esm.js:15 Uncaught TypeError: Object(...) is not a function
at Module../node_modules/@emotion/core/dist/core.browser.esm.js (core.browser.esm.js:15)
at Module../node_modules/@emotion/core/core.browser.esm.js (core.browser.esm.js:15)
at **webpack_require** (bootstrap:724)
at fn (bootstrap:101)
at Module../node_modules/@emotion/styled-base/dist/styled-base.browser.esm.js (styled-base.browser.esm.js:1)
Expand Down
4 changes: 2 additions & 2 deletions code/.eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ ember-output
!.eslintrc.js
!.eslintrc-markdown.js
!.storybook
lib/core-common/templates/base-preview-head.html
lib/core-server/src/utils/__search-files-tests__
core/assets
core/src/core-server/utils/__search-files-tests__
22 changes: 5 additions & 17 deletions code/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ const addonsPackages = fs
const libPackages = fs
.readdirSync(path.join(__dirname, 'lib'))
.filter((p) => fs.statSync(path.join(__dirname, 'lib', p)).isDirectory());
const uiPackages = fs
.readdirSync(path.join(__dirname, 'ui'))
.filter((p) => fs.statSync(path.join(__dirname, 'ui', p)).isDirectory())
.filter((p) => !p.startsWith('.'));

module.exports = {
root: true,
Expand All @@ -23,6 +19,7 @@ module.exports = {
},
plugins: ['local-rules'],
rules: {
'import/no-unresolved': 'off', // covered by typescript
'eslint-comments/disable-enable-pair': ['error', { allowWholeFile: true }],
'eslint-comments/no-unused-disable': 'error',
'react-hooks/rules-of-hooks': 'off',
Expand Down Expand Up @@ -93,20 +90,20 @@ module.exports = {
{
// these packages use pre-bundling, dependencies will be bundled, and will be in devDepenencies
files: ['frameworks/**/*', 'builders/**/*', 'deprecated/**/*', 'renderers/**/*'],
excludedFiles: ['frameworks/angular/**/*', 'frameworks/ember/**/*', 'lib/core-server/**/*'],
excludedFiles: ['frameworks/angular/**/*', 'frameworks/ember/**/*', 'core/**/*'],
rules: {
'import/no-extraneous-dependencies': [
'error',
{ bundledDependencies: false, devDependencies: true },
{ bundledDependencies: false, devDependencies: true, peerDependencies: true },
],
},
},
{
files: ['**/ui/.storybook/**'],
files: ['**/.storybook/**'],
rules: {
'import/no-extraneous-dependencies': [
'error',
{ packageDir: [__dirname], devDependencies: true },
{ packageDir: [__dirname], devDependencies: true, peerDependencies: true },
],
},
},
Expand All @@ -122,15 +119,6 @@ module.exports = {
],
},
})),
...uiPackages.map((directory) => ({
files: [path.join('**', 'ui', directory, '**', '*.*')],
rules: {
'import/no-extraneous-dependencies': [
'error',
{ packageDir: [__dirname, path.join(__dirname, 'ui', directory)], devDependencies: true },
],
},
})),
...libPackages.map((directory) => ({
files: [path.join('**', 'lib', directory, '**', '*.*')],
rules: {
Expand Down
File renamed without changes.
Loading