-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPC: Core Package Consolidation #27039
Merged
Merged
Changes from all commits
Commits
Show all changes
365 commits
Select commit
Hold shift + click to select a range
c5290fa
remove tempy useage, because it's underlaying lib: temp-dir uses top-…
ndelangen bd1a212
change test to use core package
ndelangen 8b48039
redirect imports
ndelangen 0dd63f6
redirect imports
ndelangen a53f8e3
upgrade express
ndelangen dd039c8
add node install step (should be using nvmrc)
ndelangen e63f636
change circle config
ndelangen 0aa14e2
Merge branch 'next' into norbert/cpc
ndelangen df0f14a
move manager-api
ndelangen 7b0b333
fix
ndelangen 98165f0
move preview
ndelangen 8301aac
fixes
ndelangen 9d67e56
fixes
ndelangen 644721e
fixes
ndelangen a9070a8
fixes
ndelangen a5486e6
fix
ndelangen 654c606
fixes
ndelangen 436b3db
fixes
ndelangen 325d7bb
fix
ndelangen c240f55
isolate sb/test package
ndelangen d002240
hack for sb/test package
ndelangen d3616d9
move sb/test
ndelangen ff91517
improve
ndelangen bc6bd59
move ui/components
ndelangen e977c2e
fixes
ndelangen dad097c
fixes
ndelangen 553bb2b
improve
ndelangen 3542fae
fix
ndelangen 9f4648d
fix
ndelangen 559d57f
fixes
ndelangen df86c22
fix
ndelangen 7265e2f
fix
ndelangen 7bfb034
Merge branch 'next' into norbert/cpc
ndelangen fa216bd
fixes
ndelangen e2057b8
fix
ndelangen cc20d49
fixes
ndelangen 79e7ab7
fixes
ndelangen 4a93f7f
fix
ndelangen a8134a4
sort
ndelangen 5c08752
Merge branch 'next' into norbert/cpc
ndelangen 0aaa35f
fix
ndelangen 6f2e316
fix order of export maps
ndelangen 9b65392
fixes
ndelangen e108739
Merge branch 'next' into norbert/cpc
ndelangen 0a4522a
add retry
ndelangen 1cfa32f
fix
ndelangen 64cc3a9
fix
ndelangen 383c01e
use core for tests
ndelangen 773cdbb
move fonts
ndelangen 3e38e70
move ui/manager
ndelangen c26eea8
cleanup
ndelangen 50ce5c1
fixes
ndelangen c4e814d
fix
ndelangen 998bff4
fixes
ndelangen 59efad1
fix
ndelangen 7e678e9
Merge branch 'next' into norbert/cpc
ndelangen 022fe08
improve
ndelangen fbd4ac1
improve
ndelangen 6acaea4
add interactions stories, because why not?
ndelangen 17bb499
fix type issues by ignoring them... this is how it was before... but …
ndelangen d711b81
fixes
ndelangen d742884
fixes
ndelangen 588924f
Merge branch 'next' into norbert/cpc
ndelangen 6df6afa
fix
ndelangen 8294029
fix
ndelangen 5add5e5
improve
ndelangen 806e176
ignore this story, as it needs a special decorator for storybookAPI
ndelangen 1c2a20f
fix
ndelangen 790c5c6
move manager builder templates
ndelangen 616ae92
move builder-manager
ndelangen 005a37b
lint scripts
ndelangen 5132bc1
fixes
ndelangen d3adbbc
fix
ndelangen fd909fe
fix
ndelangen 49d0882
Merge branch 'next' into norbert/cpc
ndelangen a85462f
fix
ndelangen 6247c5f
fix
ndelangen b7f8950
move core-server
ndelangen 8b418a5
fix
ndelangen c7b73f1
fixes
ndelangen 4412b1c
Merge branch 'next' into norbert/cpc
ndelangen 5d8a467
fixes
ndelangen d1c47b4
fix
ndelangen 0373aca
add higher size limit to verdaccio
ndelangen 7fa53ee
fixes
ndelangen c59fe8a
externalize ws
ndelangen 5384244
fix
ndelangen 0c01551
bring back test and instrumenter
ndelangen 3299028
fix
ndelangen 73e679d
fix
ndelangen 5119a91
fix
ndelangen 3d84f45
fixes
ndelangen a897f58
fixes
ndelangen 3e09e18
fixes
ndelangen 034551c
fixes
ndelangen 914cc76
fixes
ndelangen e09c0eb
fix
ndelangen 0b0a2b6
Merge branch 'next' into norbert/cpc
ndelangen 4dbbf9d
move
ndelangen d924d14
fix
ndelangen 72ff559
fix
ndelangen 248e1a1
bump orb version
ndelangen 8c81126
Merge branch 'next' into norbert/cpc
ndelangen a7e6767
make peerDep a broad version range
ndelangen c6e00fc
fix lockfiles
ndelangen b1c4ea5
upgrade yarn & sync
ndelangen 78c6f5f
remove unused deps that gave peerDep warnings
ndelangen c84daf1
remove corepack packageManager fields
ndelangen e625ef9
add explainer
ndelangen 108cd97
undo the upgrade to test-storybook yarn versions
ndelangen 0fbc97c
add yarn version back
ndelangen 095d03a
fix
ndelangen 74cfb9c
fix
ndelangen 9bf5336
Merge branch 'next' into norbert/cpc
ndelangen 7ecba7c
ensure mapper files are always generated first
ndelangen d06e361
improve
ndelangen 5ac129b
fix for windows, hopefully with a single retry
ndelangen aa0e744
cleanup
ndelangen d7ed2dc
Merge branch 'next' into norbert/cpc
ndelangen 576a2e1
fix
ndelangen 09a88d0
Merge branch 'next' into norbert/cpc
ndelangen e388a0e
Merge branch 'next' into norbert/cpc
ndelangen 75ed6e8
fix
ndelangen 3c9c9f5
revert
ndelangen 931d63d
Merge branch 'next' into norbert/cpc
ndelangen 69eb6b8
Merge branch 'next' into norbert/cpc
ndelangen 64dd532
fix
ndelangen 6263439
Merge branch 'next' into norbert/cpc
ndelangen e35b884
drop the `/dist` part
ndelangen c53be0a
fix
ndelangen 8505d86
migrate core to use the non-dist path
ndelangen ac31f4b
get rid of the last bits referencing core/dist
ndelangen e09e9b4
final cleanup
ndelangen 525a98b
make the `storybook` package portal to `@storybook/core`
ndelangen 8e2db19
make packages peerDep on `storybook` package instead of `@storybook/c…
ndelangen cb5b778
make packages peerDep on `storybook` package instead of `@storybook/c…
ndelangen c6f9289
tried migrating the cli package to type-module to try to get vite to …
ndelangen 7c8cc56
change references from `@storybook/cli` to `storybook`
ndelangen 2ff0087
fix a few unit tests due to the cli now being type:module
ndelangen f56ef2b
fix linting
ndelangen 2d76a5f
proxy all including `storybook` package
ndelangen a452400
fix
ndelangen a18a63f
force close after publishing with --open
ndelangen 4193511
fix script to generate portal to core
ndelangen 40407a6
fix a type issue
ndelangen e40e275
trial and error
ndelangen ca0047a
fix mapping to core-events errors
ndelangen 84f2398
trying to make it work
ndelangen 147f78d
fixes
ndelangen 47b3a3f
fixes
ndelangen 6d7e1b3
add cjs files to cli package.json declaration
yannbf 8dcd2f8
Merge branch 'norbert/cpc-storybook' of github.com:storybookjs/storyb…
yannbf caecadb
fix
yannbf 127c8a5
chore: Remove commented out code in entries.ts
ndelangen c415320
disable test
ndelangen eb760b7
Update import paths for core files in update-core-portal.ts
ndelangen 4e2aa1c
cleanup
ndelangen 99e27a2
Merge branch 'next' into norbert/cpc
ndelangen 389b7e7
don't need type generation for unit tests AFAIK
ndelangen c68d8cd
bump the lockfile
ndelangen 949f878
cleanup
ndelangen 699011e
fix
ndelangen 986d090
chore: update path import to use node:path module
ndelangen b9b5982
fix test
ndelangen 7c22d90
fix test
ndelangen 05f306e
remove embedding of components into blocks
ndelangen 532d251
disable this test
ndelangen 47972ff
chore: Update path import to use node:path module
ndelangen fa5caa7
chore: Remove unused imports in entries.ts
ndelangen c1a42e0
cleanup
ndelangen d813d6c
Merge branch 'norbert/cpc' into norbert/cpc-storybook
ndelangen dca9ede
Merge pull request #28310 from storybookjs/norbert/cpc-storybook
ndelangen 1f0f923
Add `alias`s for possibly missing `peerDeps` for `addon-docs`
ndelangen 58ccf51
Add `alias`s for possibly missing `peerDeps` for `addon-docs`, for we…
ndelangen c5b7b6c
resolve common-manager
ndelangen b18a416
fix
ndelangen 868bbcf
make @storybook/core an exact dep version range
ndelangen 3c14455
Merge branch 'next' into norbert/cpc
ndelangen bff2b04
remove unused variable
ndelangen da9856d
fixing chalk
ndelangen 7bcbcd2
cleanup
ndelangen 3a13dd9
cleanup the `ui` dir
ndelangen 990b252
fix
ndelangen 34c3825
fix
ndelangen 6c55b9e
fixes
ndelangen 2affd31
fix
ndelangen 1885b55
fix
ndelangen ce79687
chore: Update chromatic.config.json and package.json
ndelangen 3604614
cleanup
ndelangen aa66843
Remove unused "Blocks Only" Storybook
JReinhold c9e78f0
fixes
ndelangen 52e8e1f
Merge pull request #28346 from storybookjs/norbert/cpc-cleanup
ndelangen b255698
delete unused facade
ndelangen 48b270c
add README for core
ndelangen a1c112a
IMprove the CLI README.md
ndelangen c694c50
additions to CONTRIBUTING.md
ndelangen 0370ab3
Merge branch 'next' into norbert/cpc
ndelangen b927c1b
hopefully fix tests on windows
yannbf b38dc62
Merge branch 'norbert/cpc' of https://github.com/storybookjs/storyboo…
yannbf a8fe212
fix tests
yannbf cf0d3f8
fix linting
ndelangen c5a75ba
fix linting issues
ndelangen 4b7f268
fix linting
ndelangen 8147701
Merge branch 'next' into norbert/cpc
ndelangen f7889a8
cleanup the paths to `./dist` in cli & core
ndelangen 8281b79
cleanup and make code modular
ndelangen 95605d9
tiny fix to the mapping for build script
ndelangen 65814b9
Merge branch 'norbert/cpc' into norbert/cpc-no-dist-in-core-exports
ndelangen c6a79d5
Merge branch 'next' into norbert/cpc
ndelangen 6b32316
hard code the verdaccio URl without proxy
ndelangen 34d820e
hard code URl to publish to
ndelangen 9dccd65
Merge branch 'next' into norbert/cpc
ndelangen 17bf89f
improve type safety of Button.tsx
ndelangen d0fd233
improve type safety of ActionBar.tsx
ndelangen e7b0508
cleanup
ndelangen ee440d3
cleanup
ndelangen bbc9c9a
chore: Refactor TabsState initial prop assignment using nullish coale…
ndelangen 5822daa
cleanup
ndelangen 9f14be5
fixing the doctor command
ndelangen df82a58
Add documentation of what the purpose of `update-core-portal`.ts` is.
ndelangen ccc1ef9
Merge branch 'next' into norbert/cpc
ndelangen 0ccbdad
cleanup
ndelangen 47ddb31
Refactor SVG animation in remount.tsx to use undefined instead of 'un…
ndelangen 8cdb768
remove use of yarn branch version
ndelangen 3d37114
Add explainer for the need of the proxy server in front of verdaccio
ndelangen 8ea8b9e
undo renaming in a docs page
ndelangen c225b59
remove @storybook/test as a peerDep from addon-actions
ndelangen f888e91
Merge branch 'next' into norbert/cpc
ndelangen 20b815f
chore: Remove @storybook/test as a peerDep from addon-actions
ndelangen 54138f1
Explain the aliases for @storybook/addon-docs & @storybook/blocks in …
ndelangen 9846f26
adding the deps for instrumenter back for addon-interaction
ndelangen 652ed9d
Merge branch 'next' into norbert/cpc
ndelangen fc1d713
Merge branch 'norbert/remove-unused-2' into norbert/cpc
ndelangen ae80878
improve/fix type generation in prod mode
ndelangen dce41a3
no longer output
ndelangen ea54a16
never have .tsx files as entries for core, as it causes inconsistent …
ndelangen 06c5a27
fix package.json
ndelangen c071d1b
Merge branch 'next' into norbert/cpc
ndelangen 0838803
improve variable names
ndelangen 3e9d8bc
generate `storybook/internal/x` in `storybook`'s `package.json`
ndelangen 3a1e61c
add an `/internal` in the path to core subpaths from `storybook`
ndelangen 170e509
add more `/internal` paths
ndelangen 4f7bc5c
Merge branch 'next' into norbert/cpc
ndelangen 0a3f1bd
sync version
ndelangen 106339e
fix linting
ndelangen 8f256ae
fix
ndelangen b5f6c2d
Merge branch 'next' into norbert/cpc
ndelangen f8466d4
remove packageManager field
ndelangen fbc1196
fix
ndelangen 1aec38d
Merge branch 'next' into norbert/cpc
ndelangen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,4 +53,5 @@ code/playwright/.cache/ | |
code/bench-results/ | ||
|
||
/packs | ||
code/.nx/cache | ||
code/.nx/cache | ||
!**/fixtures/**/yarn.lock |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we run tests in no-link mode on CI to have the most realistic experience?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unit tests are not affected by this at all.
This saves about 2 minutes of CI time.