Vite: Fix stats-plugin to normalize file names with posix paths #27218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested changes
May 25, 2024
shilman
changed the title
shilman
added
the
patch:yes
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0f899a9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
| @@ -58,7 +59,7 @@ export function pluginWebpackStats({ workingDir }: WebpackStatsPluginOptions): W | |||
| else { | |||
| const relativePath = path.relative(workingDir, stripQueryParams(filename)); | |||
There was a problem hiding this comment.
Couldn't we just use path.posix.relative here to use forward slashes, independently of the OS?
There was a problem hiding this comment.
@valentinpalkovic that is how I originally submitted this PR, until @shilman suggested using slash to be consistent with how windows paths are already converted elsewhere. I don't mind either way, if you're able to decide between you which option is preferable?
There was a problem hiding this comment.
I see. Sorry that I haven’t followed the whole conversation! It’s fine then how it is!
storybook-bot
pushed a commit
that referenced
this pull request
Jun 2, 2024
…ts-json-posix-paths Vite: Fix stats-plugin to normalize file names with posix paths (cherry picked from commit abfcc9f)
This was referenced Jun 2, 2024
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Jun 2, 2024
…ts-json-posix-paths Vite: Fix stats-plugin to normalize file names with posix paths (cherry picked from commit abfcc9f)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
…ts-json-posix-paths Vite: Fix stats-plugin to normalize file names with posix paths (cherry picked from commit abfcc9f)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
…ts-json-posix-paths Vite: Fix stats-plugin to normalize file names with posix paths (cherry picked from commit abfcc9f)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
…ts-json-posix-paths Vite: Fix stats-plugin to normalize file names with posix paths (cherry picked from commit abfcc9f)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…ts-json-posix-paths Vite: Fix stats-plugin to normalize file names with posix paths (cherry picked from commit abfcc9f)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…ts-json-posix-paths Vite: Fix stats-plugin to normalize file names with posix paths (cherry picked from commit abfcc9f)
storybook-bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…ts-json-posix-paths Vite: Fix stats-plugin to normalize file names with posix paths (cherry picked from commit abfcc9f)
github-actions
bot
added
the
patch:done
valentinpalkovic
added
needs qa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27172
What I did
Updates the
normalizefunction within thewebpack-stats-pluginforbuilder-viteto always normalize file names with posix path separators (/).Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
storybook build --stats-jsonnameandidfields in thepreview-stats.jsonfile are using posix path separators (/) and not windows separators (\\)Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>