Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency: Upgrade tempy #27366

Merged
merged 6 commits into from
May 29, 2024
Merged

Dependency: Upgrade tempy #27366

merged 6 commits into from
May 29, 2024

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented May 24, 2024

Closes #27259.

What I did

Upgraded tempy package from v1.0.1 to v3.1.0 along with its references.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented May 24, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3e29717. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman added dependencies ci:normal patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 25, 2024
@shilman
Copy link
Member

shilman commented May 25, 2024

@valentinpalkovic @ndelangen Looks like there's a top-level await that's causing issues with the CJS bundling. I tried moving it to a dev dependency to run it through tsup but that didn't solve anything. Thoughts?

@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented May 25, 2024

The correct approach is to just import tempty dynamically. Dynamic imports of ESM modules is allowed in CJS and ESM environments

const { namedImport } = await import('tempty')

Please keep in mind that this has to be imported in a function body of an async function, because top-level awaits aren't supported so far.

@valentinpalkovic valentinpalkovic self-assigned this May 27, 2024
@valentinpalkovic valentinpalkovic self-requested a review May 27, 2024 13:36
@shilman shilman merged commit cf0af1a into storybookjs:next May 29, 2024
50 of 51 checks passed
@github-actions github-actions bot mentioned this pull request May 29, 2024
9 tasks
storybook-bot pushed a commit that referenced this pull request May 29, 2024
Dependency: Upgrade tempy
(cherry picked from commit cf0af1a)
@github-actions github-actions bot mentioned this pull request May 29, 2024
7 tasks
storybook-bot pushed a commit that referenced this pull request May 29, 2024
Dependency: Upgrade tempy
(cherry picked from commit cf0af1a)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Inflight has been deprecated
3 participants