Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-info: add keys for separator spans in OneOfType #2743

Merged
merged 2 commits into from
Jan 14, 2018

Conversation

Hypnosphi
Copy link
Member

Fixes #2649

@Hypnosphi Hypnosphi requested a review from a team January 13, 2018 21:41
@Hypnosphi Hypnosphi added bug addon: info patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 13, 2018
@codecov
Copy link

codecov bot commented Jan 13, 2018

Codecov Report

Merging #2743 into master will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2743      +/-   ##
==========================================
- Coverage   33.02%   33.01%   -0.01%     
==========================================
  Files         419      419              
  Lines        9158     9160       +2     
  Branches      971      982      +11     
==========================================
  Hits         3024     3024              
+ Misses       5485     5462      -23     
- Partials      649      674      +25
Impacted Files Coverage Δ
addons/info/src/components/types/OneOfType.js 57.14% <80%> (-6.02%) ⬇️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
addons/actions/src/lib/util/typeReplacer.js 54.54% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
lib/core/src/client/preview/story_store.js 52.88% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 51.85% <0%> (ø) ⬆️
addons/actions/src/lib/types/symbol/index.js 81.25% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.42% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 7.93% <0%> (ø) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20af34a...bb1a4ce. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 8dddbe2 into master Jan 14, 2018
@amcdnl amcdnl deleted the oneoftype-separator-key branch January 14, 2018 14:55
shilman pushed a commit that referenced this pull request Jan 19, 2018
Addon-info: add keys for separator spans in OneOfType
@Hypnosphi Hypnosphi added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: info bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants