Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Update trigger conditions for Circle CI workflows #27481

Merged
merged 8 commits into from
Jun 7, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented May 31, 2024

Closes N/A

What I did

I have changed the CircleCI triggers so that CircleCI jobs aren't triggered when

  • changing the PR from draft to reviewable and the other way around
  • if labels are removed or added (except the labels ci:daily, ci:merged, ci:docs, ci:normal)

For testing purposes, I have changed the trigger event from pull_request_target to pull_request. As soon as the testing is done, I will revert this change!

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Attention: The CircleCI tasks are triggered during testing because the pull_request_trigger event will always fire (inherited from the base branch). Because of that, please just look at the "Trigger CircleCI workflow" events.

Labels
  1. Label the PR with ci:merged
  2. Wait until the following actions have run successfully:
  • Trigger CircleCI workflow / trigger-merged-tests (pull_request)
  • Trigger CircleCI workflow / trigger-merged-tests (pull_request_trigger)
  1. Add another label cli
  2. Make sure that the Trigger CircleCI workflow / trigger-merged-tests (pull_request) was skipped
  3. Push a change to the PR
  4. Make sure that both mentioned actions at the top are executed
  5. Remove the label cli
  6. Make sure that the Trigger CircleCI workflow / trigger-merged-tests (pull_request) was skipped
  7. Repeat steps 1-8, but use the following labels: ci:daily, ci:normal, ci:docs
Draft / Review
  1. Label the PR with ci:merged
  2. Wait until the following actions have run successfully:
  • Trigger CircleCI workflow / trigger-merged-tests (pull_request)
  • Trigger CircleCI workflow / trigger-merged-tests (pull_request_trigger)
  1. Convert the PR to a draft
  2. Make sure that the Trigger CircleCI workflow / trigger-merged-tests (pull_request) was skipped

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this May 31, 2024
@valentinpalkovic valentinpalkovic added ci:docs Run the CI jobs for documentation checks only. build Internal-facing build tooling & test updates labels May 31, 2024
Copy link

nx-cloud bot commented May 31, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit df6d614. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic force-pushed the valentin/improve-ci-triggers branch 2 times, most recently from a602c03 to 6f70196 Compare May 31, 2024 11:25
@valentinpalkovic valentinpalkovic force-pushed the valentin/improve-ci-triggers branch from 5876f4b to b5331b2 Compare May 31, 2024 11:38
@valentinpalkovic valentinpalkovic added cli ci:merged Run the CI jobs that normally run when merged. accessibility and removed addon: a11y cli ci:docs Run the CI jobs for documentation checks only. labels May 31, 2024
@valentinpalkovic valentinpalkovic marked this pull request as ready for review May 31, 2024 11:59
@valentinpalkovic valentinpalkovic marked this pull request as draft May 31, 2024 12:00
@valentinpalkovic valentinpalkovic marked this pull request as ready for review June 4, 2024 11:20
@valentinpalkovic valentinpalkovic force-pushed the valentin/improve-ci-triggers branch from ebebb8d to f783605 Compare June 7, 2024 13:03
@valentinpalkovic valentinpalkovic merged commit dfe9d46 into next Jun 7, 2024
13 of 16 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/improve-ci-triggers branch June 7, 2024 13:04
@github-actions github-actions bot mentioned this pull request Jun 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant