-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Update trigger conditions for Circle CI workflows #27481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
ci:docs
Run the CI jobs for documentation checks only.
build
Internal-facing build tooling & test updates
labels
May 31, 2024
☁️ Nx Cloud ReportCI is running/has finished running commands for commit df6d614. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
valentinpalkovic
force-pushed
the
valentin/improve-ci-triggers
branch
2 times, most recently
from
May 31, 2024 11:25
a602c03
to
6f70196
Compare
valentinpalkovic
force-pushed
the
valentin/improve-ci-triggers
branch
from
May 31, 2024 11:27
6f70196
to
09653c1
Compare
valentinpalkovic
force-pushed
the
valentin/improve-ci-triggers
branch
from
May 31, 2024 11:38
5876f4b
to
b5331b2
Compare
valentinpalkovic
added
cli
ci:merged
Run the CI jobs that normally run when merged.
accessibility
and removed
addon: a11y
cli
ci:docs
Run the CI jobs for documentation checks only.
labels
May 31, 2024
valentinpalkovic
force-pushed
the
valentin/improve-ci-triggers
branch
from
June 7, 2024 13:03
ebebb8d
to
f783605
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
I have changed the CircleCI triggers so that CircleCI jobs aren't triggered when
For testing purposes, I have changed the trigger event from
pull_request_target
topull_request
. As soon as the testing is done, I will revert this change!Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Attention: The CircleCI tasks are triggered during testing because the
pull_request_trigger
event will always fire (inherited from the base branch). Because of that, please just look at the "Trigger CircleCI workflow" events.Labels
ci:merged
cli
Trigger CircleCI workflow / trigger-merged-tests (pull_request)
was skippedcli
Trigger CircleCI workflow / trigger-merged-tests (pull_request)
was skippedci:daily
,ci:normal
,ci:docs
Draft / Review
ci:merged
Trigger CircleCI workflow / trigger-merged-tests (pull_request)
was skippedDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>