Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Storyshots README, add missing export for image snapshots #2759

Conversation

thomasbertet
Copy link
Contributor

@thomasbertet thomasbertet commented Jan 16, 2018

Issue:

What I did

  • Add missing export to README (& minor fix to other parts of README)

How to test

  • Open the README and read it 😄
    Is this testable with jest or storyshots?
    No
    Does this need a new example in the kitchen sink apps?
    No
    Does this need an update to the documentation?
    Yep
    If your answer is yes to any of these, please make sure to include it in your PR.

@thomasbertet thomasbertet force-pushed the fix-storyshots-readme-missing-export branch from 54ba889 to 553f023 Compare January 16, 2018 09:14
@codecov
Copy link

codecov bot commented Jan 16, 2018

Codecov Report

Merging #2759 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2759   +/-   ##
=======================================
  Coverage   35.73%   35.73%           
=======================================
  Files         433      433           
  Lines        9430     9430           
  Branches     1020     1000   -20     
=======================================
  Hits         3370     3370           
- Misses       5376     5387   +11     
+ Partials      684      673   -11
Impacted Files Coverage Δ
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/storyshots/src/rn/loader.js 53.33% <0%> (ø) ⬆️
addons/viewport/src/components/viewportInfo.js 36.36% <0%> (ø) ⬆️
lib/core/src/client/preview/story_store.js 84.21% <0%> (ø) ⬆️
...ddons/actions/src/containers/ActionLogger/index.js 49.25% <0%> (ø) ⬆️
addons/a11y/src/components/Tabs.js 0% <0%> (ø) ⬆️
addons/storyshots/src/react/renderShallowTree.js 57.14% <0%> (ø) ⬆️
addons/a11y/src/components/Report/RerunButton.js 0% <0%> (ø) ⬆️
app/angular/src/server/ts_config.js 40.9% <0%> (ø) ⬆️
addons/actions/src/lib/util/typeReviver.js 71.42% <0%> (ø) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe0ca8...23cb115. Read the comment docs.

@thomasbertet thomasbertet force-pushed the fix-storyshots-readme-missing-export branch from 553f023 to 73c33ff Compare January 16, 2018 09:32
@thomasbertet thomasbertet force-pushed the fix-storyshots-readme-missing-export branch from 73c33ff to 23cb115 Compare January 16, 2018 09:35
@Hypnosphi Hypnosphi merged commit e95e154 into storybookjs:master Jan 16, 2018
@thomasbertet thomasbertet deleted the fix-storyshots-readme-missing-export branch January 16, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants