Updating css-style testing docs to mention StoryShots image snapshots feature #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2767 +/- ##
=======================================
Coverage 35.75% 35.75%
=======================================
Files 433 433
Lines 9441 9441
Branches 1005 992 -13
=======================================
Hits 3376 3376
- Misses 5376 5413 +37
+ Partials 689 652 -37
Continue to review full report at Codecov.
|
Hypnosphi
requested changes
Jan 17, 2018
|
|
||
| It will be hard to use all the frameworks we've [mentioned](/testing/react-ui-testing#3-css-style-testing), but we'll be able to use frameworks which are based on URL as the input source. (Such as [BackstopJS](https://github.com/garris/BackstopJS) and [Gemini](https://github.com/gemini-testing/gemini)) | ||
|
|
||
| - [Loki](https://loki.js.org/): Is a great tool for visual regression testing. |
There was a problem hiding this comment.
I think all those tools are still worth mentioning
Hypnosphi
approved these changes
Jan 17, 2018
|
@tmeasday would you like Chromatic to be mentioned here as well? |
ndelangen
approved these changes
Jan 17, 2018
|
@Hypnosphi sure! We should mention the other commercial offerings that support storybook too: Percy and Screener. |
|
@Hypnosphi should I do that here? Or should those be added in a separate PR? |
|
@anescobar1991 as you wish =) |
|
@Hypnosphi I added them in 728cad8 :) |
Hypnosphi
reviewed
Jan 18, 2018
| - [StoryShots](https://github.com/storybooks/storybook/tree/master/addons/storyshots) with its [seamless integration](https://github.com/storybooks/storybook/tree/master/addons/storyshots#configure-storyshots-for-image-snapshots) with [jest-image-snapshot](https://github.com/americanexpress/jest-image-snapshot) | ||
| - [Loki](https://loki.js.org/) | ||
| - [Perci](https://percy.io/docs/clients/javascript/react-storybook) | ||
| - [Screener](https://screener.io/v2/docs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: With #2413 being merged into master and adding image snapshot capabilities into StoryShots the documentation should reflect the change.
What I did
Updated css-style-testing doc to mention StoryShots integration with
jest-image-snapshotHow to test
View doc in markdown editor.