Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular inheritance example #2787

Merged
merged 5 commits into from
Jan 20, 2018
Merged

Angular inheritance example #2787

merged 5 commits into from
Jan 20, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Jan 19, 2018

Issue: #2778

What I did

Added story with inheritance to the angular-cli example

@igor-dv igor-dv self-assigned this Jan 19, 2018
@igor-dv igor-dv requested a review from alterx January 19, 2018 18:33
@Hypnosphi Hypnosphi added documentation maintenance User-facing maintenance tasks labels Jan 19, 2018
@codecov
Copy link

codecov bot commented Jan 19, 2018

Codecov Report

Merging #2787 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2787   +/-   ##
=======================================
  Coverage   35.51%   35.51%           
=======================================
  Files         434      434           
  Lines        9501     9501           
  Branches      999      997    -2     
=======================================
  Hits         3374     3374           
+ Misses       5469     5465    -4     
- Partials      658      662    +4
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-76.67%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/components/src/table/table.js 83.33% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/search_box.js 36.36% <0%> (ø) ⬆️
...i/src/modules/ui/components/stories_panel/index.js 20.96% <0%> (ø) ⬆️
app/angular/src/server/ts_config.js 38.09% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Item.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Tabs.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b98a8...ef9d0b2. Read the comment docs.

@igor-dv igor-dv merged commit 8bc13f7 into master Jan 20, 2018
@igor-dv igor-dv deleted the angular-inheritance-example branch January 20, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular documentation maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants