Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix css warning in angular-cli example #2789

Merged
merged 4 commits into from
Jan 21, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Jan 20, 2018

Issue: #2735 (comment)

What I did

Moved the css-rules-warning class to style.css

@igor-dv igor-dv self-assigned this Jan 20, 2018
@igor-dv igor-dv added maintenance User-facing maintenance tasks angular labels Jan 20, 2018
Copy link
Contributor

@Quramy Quramy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igor-dv 👍

@codecov
Copy link

codecov bot commented Jan 20, 2018

Codecov Report

Merging #2789 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2789   +/-   ##
=======================================
  Coverage   35.83%   35.83%           
=======================================
  Files         427      427           
  Lines        9422     9422           
  Branches      953      957    +4     
=======================================
  Hits         3376     3376           
+ Misses       5434     5410   -24     
- Partials      612      636   +24
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-76.67%) ⬇️
app/polymer/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/graphql/src/components/FullScreen/index.js 0% <0%> (ø) ⬆️
addons/storyshots/src/vue/renderTree.js 60% <0%> (ø) ⬆️
app/angular/src/server/ts_config.js 38.09% <0%> (ø) ⬆️
addons/a11y/src/components/Report/RerunButton.js 0% <0%> (ø) ⬆️
lib/ui/src/libs/withLifecycleDecorator.js 17.14% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/a11y/src/components/Report/index.js 0% <0%> (ø) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d35eb...2b5959b. Read the comment docs.

@igor-dv igor-dv merged commit 23f6f65 into master Jan 21, 2018
@igor-dv igor-dv deleted the fix-css-warning-in-angular-example branch January 21, 2018 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants