CSF: Make initialGlobals
change only on the external API
#28161
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
Telescopes on #27517
What I did
Update #27517 to use
initialGlobals
for the external API, but continue to useX.globals
as the internal return type fromnormalizeGlobals
.Also return both
X.globals
ANDX.initialGlobals
fromcomposeConfigs
for backwards compatibility.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
initialGlobals
in its.storybook/preview.js
.globals
and verify that everything still works.Documentation
Intentionally leaving this undocumented for now. The
preview.js
globals
annotation was also undocumented.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>