Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix the CRA sandbox not being link-able #28240

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

ndelangen
Copy link
Member

What I did

CRA sandbox is lagging behind in their dependencies, so it has become unlinkable with our monorepo.

This PR adds a few extra resolutions so it can be linked again.

It also removes the packageManager fields, as the newest version of yarn doesn't like it, when not using corepack. (which we are not).

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Jun 13, 2024
@ndelangen ndelangen self-assigned this Jun 13, 2024
@ndelangen ndelangen changed the title fix the cra not being able to link by forcing resolutions Build: Fix the cra sandbox not being link-able Jun 13, 2024
@ndelangen ndelangen changed the title Build: Fix the cra sandbox not being link-able Build: Fix the CRA sandbox not being link-able Jun 13, 2024
Copy link

nx-cloud bot commented Jun 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c55972e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@ndelangen ndelangen merged commit 08d51e8 into next Jun 18, 2024
66 of 70 checks passed
@ndelangen ndelangen deleted the norbert/add-alias-cra branch June 18, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant