Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extending webpack section is no longer needed for the common usage #2826

Merged

Conversation

Quramy
Copy link
Contributor

@Quramy Quramy commented Jan 24, 2018

Issue: #2688

What I did

I Removed extending webpack config section from Angular guide because I think this section gets worthless via #2688 and #2735 .

Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@igor-dv igor-dv added maintenance User-facing maintenance tasks documentation angular labels Jan 24, 2018
@codecov
Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #2826 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2826   +/-   ##
=======================================
  Coverage   35.87%   35.87%           
=======================================
  Files         427      427           
  Lines        9411     9411           
  Branches      977      964   -13     
=======================================
  Hits         3376     3376           
- Misses       5369     5407   +38     
+ Partials      666      628   -38
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/info/src/components/types/PropertyLabel.js 78.94% <0%> (ø) ⬆️
addons/links/src/react/components/link.js 78.78% <0%> (ø) ⬆️
addons/actions/src/lib/types/symbol/index.js 81.25% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Elements.js 0% <0%> (ø) ⬆️
addons/jest/src/components/Indicator.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
addons/actions/src/lib/util/getPropertiesList.js 60% <0%> (ø) ⬆️
...s/actions/src/lib/types/function/createFunction.js 53.33% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Rules.js 0% <0%> (ø) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da35aa9...cd1d3d0. Read the comment docs.

@igor-dv igor-dv merged commit 1db26ce into storybookjs:master Jan 24, 2018
@Quramy Quramy deleted the angular-remove-css-workaround-guide branch January 24, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular documentation maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants