Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Allow format configuration of custom source preview #28305

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

64BitAsura
Copy link
Contributor

@64BitAsura 64BitAsura commented Jun 21, 2024

Closes #28341

What I did

Small change to angular framework, to make format as optional and stopping it enforced all the time in preview source

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Jun 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7659b22. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@64BitAsura 64BitAsura changed the title Next bug: storybook angular format is optional Jun 21, 2024
@yannbf
Copy link
Member

yannbf commented Jun 24, 2024

Hey @64BitAsura thanks for your contribution. Would you mind creating a GH issue explaining what exactly you're trying to solve in this PR? It's a bit unclear right now. If you elaborate the issue we can better review this and see whether there are more changes needed to be done. Thanks!

@yannbf yannbf requested a review from valentinpalkovic June 24, 2024 13:15
@64BitAsura
Copy link
Contributor Author

Hey @64BitAsura thanks for your contribution. Would you mind creating a GH issue explaining what exactly you're trying to solve in this PR? It's a bit unclear right now. If you elaborate the issue we can better review this and see whether there are more changes needed to be done. Thanks!

As requested #28341

@valentinpalkovic valentinpalkovic changed the title bug: storybook angular format is optional Bug: Storybook angular format is optional Jul 3, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Made format optional in code/frameworks/angular/src/client/docs/sourceDecorator.ts
  • Ensured format is not enforced in preview source
  • Increased flexibility in source rendering for Angular framework

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@valentinpalkovic
Copy link
Contributor

Thanks for your contribution! LGTM!

@valentinpalkovic valentinpalkovic changed the title Bug: Storybook angular format is optional Angular: Allow format configuration of custom source preview Jul 3, 2024
@valentinpalkovic valentinpalkovic merged commit 5196fdf into storybookjs:next Jul 3, 2024
51 of 52 checks passed
@valentinpalkovic valentinpalkovic added needs qa Indicates that this needs manual QA during the upcoming minor/major release and removed needs qa Indicates that this needs manual QA during the upcoming minor/major release labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook angular custom source preview broken because of Prettier Angular praser is enforced
3 participants