-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPC: Use storybook
package as the peerDep
#28310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d813d6c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
ndelangen
force-pushed
the
norbert/cpc-storybook
branch
from
June 21, 2024 16:18
3a2276d
to
676c76e
Compare
ndelangen
force-pushed
the
norbert/cpc-storybook
branch
from
June 21, 2024 20:28
676c76e
to
cb5b778
Compare
…ook into norbert/cpc-storybook
ndelangen
force-pushed
the
norbert/cpc-storybook
branch
from
June 24, 2024 13:18
544c0dc
to
eb760b7
Compare
ndelangen
added
ci:daily
Run the CI jobs that normally run in the daily job.
and removed
ci:normal
labels
Jun 24, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
storybook
a portal to@storybook/core
@storybook/core/preview-api
becomesstorybook/preview-api
for example.exports
field incore/package.json
is "synced" withlib/cli/package.json
theming
,components
that were breaking the use of theexports
-field.@radix-ui/*
packages were left in place incomponents
, but also not a normal dependency, which brokeaddon-docs
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-28310-sha-4e2aa1c7
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-28310-sha-4e2aa1c7 sandbox
or in an existing project withnpx storybook@0.0.0-pr-28310-sha-4e2aa1c7 upgrade
.More information
0.0.0-pr-28310-sha-4e2aa1c7
norbert/cpc-storybook
4e2aa1c7
1719241616
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28310