Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPC: Use storybook package as the peerDep #28310

Merged
merged 26 commits into from
Jun 25, 2024
Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 21, 2024

What I did

  • I made storybook a portal to @storybook/core
    • @storybook/core/preview-api becomes storybook/preview-api for example.
    • The exports field in core/package.json is "synced" with lib/cli/package.json
    • Shim files are generated
  • Removed aliasses to theming, components that were breaking the use of the exports-field.
  • Fixed issue where @radix-ui/* packages were left in place in components, but also not a normal dependency, which broke addon-docs
  • I disabled a unit test, that was broken, and doesn't seem likely to be fixable right now. We already get coverage on that functionality via e2e test.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-28310-sha-4e2aa1c7. Try it out in a new sandbox by running npx storybook@0.0.0-pr-28310-sha-4e2aa1c7 sandbox or in an existing project with npx storybook@0.0.0-pr-28310-sha-4e2aa1c7 upgrade.

More information
Published version 0.0.0-pr-28310-sha-4e2aa1c7
Triggered by @yannbf
Repository storybookjs/storybook
Branch norbert/cpc-storybook
Commit 4e2aa1c7
Datetime Mon Jun 24 15:06:56 UTC 2024 (1719241616)
Workflow run 9647785449

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28310

Copy link

nx-cloud bot commented Jun 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d813d6c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many -t build --parallel=3

Sent with 💌 from NxCloud.

@ndelangen ndelangen force-pushed the norbert/cpc-storybook branch from 3a2276d to 676c76e Compare June 21, 2024 16:18
@ndelangen ndelangen force-pushed the norbert/cpc-storybook branch from 676c76e to cb5b778 Compare June 21, 2024 20:28
@ndelangen ndelangen force-pushed the norbert/cpc-storybook branch from 544c0dc to eb760b7 Compare June 24, 2024 13:18
@ndelangen ndelangen added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:normal labels Jun 24, 2024
@ndelangen ndelangen marked this pull request as ready for review June 24, 2024 14:47
@ndelangen ndelangen merged commit dca9ede into norbert/cpc Jun 25, 2024
27 of 30 checks passed
@ndelangen ndelangen deleted the norbert/cpc-storybook branch June 25, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. core feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants