Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28307
What I did
When we prebundle libraries it resolves ESM/CJS issues like #28307 because we publish CJS versions of
Did not have a good repro for the problem but verified with the user that the canary fixes the problem in their project. I also tested it in a fresh project on my local machine.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
parameters: { docs: { toc: {} } }
in.storybook/preview.ts
🦋 Canary release
This pull request has been released as version
0.0.0-pr-28318-sha-24019b5c
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-28318-sha-24019b5c sandbox
or in an existing project withnpx storybook@0.0.0-pr-28318-sha-24019b5c upgrade
.More information
0.0.0-pr-28318-sha-24019b5c
shilman/28307-prebundle-tocbot
24019b5c
1719147019
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28318