Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Set env.bugfixes in SWC so destructuring is never transpiled #28363

Merged
merged 9 commits into from
Jun 27, 2024

Conversation

kasperpeulen
Copy link
Contributor

What I did

Set the env.bugfixes option in SWC by default.

env. bugfixes transpiles the broken syntax to the closest non-broken modern syntax.

E.g. it won't transpile parameter destructuring in Safari,
which would break how we detect if the mount context property is used in the play function.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kasperpeulen kasperpeulen added ci:daily Run the CI jobs that normally run in the daily job. bug labels Jun 26, 2024
Copy link

nx-cloud bot commented Jun 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0ce6a40. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen marked this pull request as ready for review June 27, 2024 12:22
@kasperpeulen kasperpeulen merged commit 25aa1dc into next Jun 27, 2024
99 of 105 checks passed
@kasperpeulen kasperpeulen deleted the kasper/swc-bugfixes branch June 27, 2024 13:46
@shilman shilman changed the title Build: Set the env.bugfixes option in SWC to make sure destructuring is never transpiled Build: Set env.bugfixes in SWC to ensure destructuring is never transpiled Jul 1, 2024
@shilman shilman changed the title Build: Set env.bugfixes in SWC to ensure destructuring is never transpiled Next: Set env.bugfixes in SWC to ensure destructuring is never transpiled Jul 1, 2024
@shilman shilman changed the title Next: Set env.bugfixes in SWC to ensure destructuring is never transpiled Next.js: Set env.bugfixes in SWC so destructuring is never transpiled Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants