Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPC: Remove externalization of memoizerific and remove need for util-deprecate #28410

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 1, 2024

What I did

  • I no longer externalize memoizerific in component
  • I've removed the need to have util-deprecate and thus removed it as a dependency.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-28410-sha-1e4b8fe0. Try it out in a new sandbox by running npx storybook@0.0.0-pr-28410-sha-1e4b8fe0 sandbox or in an existing project with npx storybook@0.0.0-pr-28410-sha-1e4b8fe0 upgrade.

More information
Published version 0.0.0-pr-28410-sha-1e4b8fe0
Triggered by @ndelangen
Repository storybookjs/storybook
Branch norbert/cpc-followup
Commit 1e4b8fe0
Datetime Mon Jul 1 12:51:55 UTC 2024 (1719838315)
Workflow run 9744567016

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28410

@ndelangen ndelangen self-assigned this Jul 1, 2024
@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:normal labels Jul 1, 2024
@ndelangen ndelangen requested a review from yannbf July 1, 2024 12:48
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: it worked great!
LGTM, I'll wait for the canary to test it out

Copy link

nx-cloud bot commented Jul 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e9bc1e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen merged commit 4931b38 into next Jul 1, 2024
54 checks passed
@ndelangen ndelangen deleted the norbert/cpc-followup branch July 1, 2024 13:57
@valentinpalkovic valentinpalkovic added bug and removed build Internal-facing build tooling & test updates labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants