Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Stop prompting about crash reports in CI #28433

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jul 3, 2024

Closes #22510

What I did

Seems like we made skipping prompting in CI only possible when in a test environment, which ended up affecting users. This PR removes that. I am not sure which test exactly this change is going to cause a regression in our tests, but if all tests pass I'd say we should just merge and avoid having this regression affect users.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Jul 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit de7d3b3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf changed the title Telemetry: stop prompting about crash reports in CI Telemetry: Stop prompting about crash reports in CI Jul 3, 2024
@yannbf yannbf marked this pull request as ready for review July 3, 2024 10:33
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Removed process.env.NODE_ENV !== 'test' check in promptCrashReports function
  • Now skips crash report prompts in any CI environment regardless of NODE_ENV value
  • Updated logic in /code/core/src/core-server/withTelemetry.ts

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Updated error stack trace formatting in code/lib/blocks/src/examples/Button.stories.tsx for ErrorStory
  • Ensured consistency in error stack trace format for testing purposes

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@yannbf yannbf merged commit cbadff4 into next Jul 3, 2024
55 checks passed
@yannbf yannbf deleted the yann/fix-telemetry-prompting-in-ci branch July 3, 2024 12:06
@valentinpalkovic valentinpalkovic added the needs qa Indicates that this needs manual QA during the upcoming minor/major release label Jul 4, 2024
@ghengeveld ghengeveld removed the needs qa Indicates that this needs manual QA during the upcoming minor/major release label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook asks to send Crash report on all errors
4 participants