Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-storyshots: upgrade puppeteer to 1.0.0 #2853

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Jan 27, 2018

Issue: #2731

We don't actually use any of the changed APIs


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 27, 2018

Codecov Report

Merging #2853 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2853   +/-   ##
=======================================
  Coverage   37.48%   37.48%           
=======================================
  Files         434      434           
  Lines        9389     9389           
  Branches      908      887   -21     
=======================================
  Hits         3519     3519           
- Misses       5301     5347   +46     
+ Partials      569      523   -46
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-100%) ⬇️
app/polymer/src/server/babel_config.js 0% <0%> (-76.67%) ⬇️
lib/ui/src/modules/ui/components/search_box.js 36.36% <0%> (ø) ⬆️
addons/info/src/components/markdown/pre/pre.js 77.58% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 84.25% <0%> (ø) ⬆️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (ø) ⬆️
lib/components/src/table/cell.js 65.21% <0%> (ø) ⬆️
addons/knobs/src/angular/helpers.js 76.97% <0%> (ø) ⬆️
addons/a11y/src/components/Report/RerunButton.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 39.02% <0%> (ø) ⬆️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf388e...53dd54a. Read the comment docs.

@Hypnosphi Hypnosphi requested a review from a team February 15, 2018 11:54
@Hypnosphi Hypnosphi merged commit 0a0fc1b into master Feb 20, 2018
@Hypnosphi Hypnosphi deleted the upgrade-puppeteer branch February 20, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants