-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Fix invalid docs links in Configure.mdx template page #28560
Conversation
- Use query param instead of embedding renderer in URL - Coerce `vue3` to `vue` (see code comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Updated URLs in
Configure.mdx
files to use query parameters for the renderer - Coerced
vue3
renderer value tovue
for documentation links - Standardized documentation links to reduce the risk of broken links
- Modified
helpers.ts
to align renderer type with documentation site usage
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f0731ef. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Bug: Fix invalid docs links in Configure.mdx template page (cherry picked from commit 0c85715)
Bug: Fix invalid docs links in Configure.mdx template page (cherry picked from commit 0c85715)
Bug: Fix invalid docs links in Configure.mdx template page (cherry picked from commit 0c85715)
Bug: Fix invalid docs links in Configure.mdx template page (cherry picked from commit 0c85715)
Bug: Fix invalid docs links in Configure.mdx template page (cherry picked from commit 0c85715)
Bug: Fix invalid docs links in Configure.mdx template page (cherry picked from commit 0c85715)
Bug: Fix invalid docs links in Configure.mdx template page (cherry picked from commit 0c85715)
Bug: Fix invalid docs links in Configure.mdx template page (cherry picked from commit 0c85715)
What I did
https://storybook.js.org/docs/{{renderer}}/configure/styling-and-css
→https://storybook.js.org/docs/configure/styling-and-css/?renderer={{renderer}}
vue3
tovue
vue
for bothvue
&vue3
renderersChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
vue3
template, e.g.yarn task --task sandbox --start-from auto --template vue3-vite/default-ts
vue
, if you were on a different one before.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>