Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: remove the frustrating zero #2857

Merged
merged 2 commits into from
Jan 28, 2018
Merged

UI: remove the frustrating zero #2857

merged 2 commits into from
Jan 28, 2018

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Jan 28, 2018

Issue:
screen shot 2018-01-28 at 15 34 56

The issue was introduced with #2451, so it's only present on alpha releases


This change is Reviewable

@@ -25,7 +25,7 @@ const storyProps = [
];

function hierarchyContainsStories(storiesHierarchy) {
return storiesHierarchy && storiesHierarchy.map.size;
return storiesHierarchy && storiesHierarchy.map.size > 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a place for easter eggs 😁

@codecov
Copy link

codecov bot commented Jan 28, 2018

Codecov Report

Merging #2857 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2857   +/-   ##
=======================================
  Coverage   35.82%   35.82%           
=======================================
  Files         428      428           
  Lines        9423     9423           
  Branches      967      987   +20     
=======================================
  Hits         3376     3376           
- Misses       5404     5408    +4     
+ Partials      643      639    -4
Impacted Files Coverage Δ
...i/src/modules/ui/components/stories_panel/index.js 20.96% <100%> (ø) ⬆️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
app/react-native/src/bin/storybook.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
addons/actions/src/lib/types/symbol/index.js 81.25% <0%> (ø) ⬆️
...dons/actions/src/lib/types/object/getObjectName.js 62.5% <0%> (ø) ⬆️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
lib/core/src/client/manager/preview.js 0% <0%> (ø) ⬆️
app/react/src/demo/Welcome.js 64.7% <0%> (ø) ⬆️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acae5ec...0c9cf3b. Read the comment docs.

@Hypnosphi Hypnosphi merged commit a1bcd2c into master Jan 28, 2018
@Hypnosphi Hypnosphi deleted the remove-zero branch January 28, 2018 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants