Added "key" prop to list items inside test failure message. #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
added
bug
addon: jest
patch:yes
Hypnosphi
reviewed
Feb 1, 2018
addons/jest/src/components/Result.js
Outdated
| @@ -35,7 +35,7 @@ const StackTrace = glamorous(({ trace, className }) => ( | |||
| .join('') | |||
| .trim() | |||
| .split(/\n/) | |||
| .map(i => <div>{i.trim()}</div>)} | |||
| .map(traceLine, traceLineIndex => <div key={traceLineIndex}>{traceLine.trim()}</div>)} | |||
There was a problem hiding this comment.
Is there a chance we can use something other than index as a key? Otherwise, I think you can suppress the corresponding eslint rule for this line
There was a problem hiding this comment.
I'd like to use something else for the key prop but can't find any reasonable alternatives. I will add the ESLint rule.
Codecov Report
@@ Coverage Diff @@
## master #2867 +/- ##
=========================================
Coverage ? 37.37%
=========================================
Files ? 426
Lines ? 9157
Branches ? 848
=========================================
Hits ? 3422
Misses ? 5234
Partials ? 501
Continue to review full report at Codecov.
|
Hypnosphi
approved these changes
Feb 2, 2018
shilman
pushed a commit
that referenced
this pull request
Feb 21, 2018
Added "key" prop to list items inside test failure message.
Hypnosphi
added
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
React complains about missing "key" prop in lists displaying a failed Jest test.
What I did
Added "key" prop equal the list element's index on the list.
How to test
Create a failing Jest test, let jest output results to a JSON file and have that file load be loaded by Storybook's Jest addon.
Is this testable with jest or storyshots?
Jest's output JSON file containing information about a failed test is required.
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
No
If your answer is yes to any of these, please make sure to include it in your PR.