Next.js: Make RSC portable-stories compatible #28756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -11,14 +11,15 @@ export const previewAnnotations: PresetProperty<'previewAnnotations'> = async ( | |||
| options | |||
| ) => { | |||
| const docsConfig = await options.presets.apply('docs', {}, options); | |||
| const features = await options.presets.apply('features', {}, options); | |||
There was a problem hiding this comment.
style: Ensure features object is correctly populated to avoid potential issues with feature flags.
yannbf
approved these changes
Jul 30, 2024
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d271575. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
valentinpalkovic
force-pushed
the
valentin/rsc-portable-stories-compat
branch
from
b7d9207
to
d271575
Compare
14 tasks
This was referenced Oct 3, 2024
This was referenced Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
Made RSC portable-stories compatible.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Manual testing is not necessary. Automated tests cover this bugfix.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-28756-sha-d271575c. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-28756-sha-d271575c sandboxor in an existing project withnpx storybook@0.0.0-pr-28756-sha-d271575c upgrade.More information
0.0.0-pr-28756-sha-d271575cvalentin/rsc-portable-stories-compatd271575c1722403781)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28756Greptile Summary
Updated
preset.tsto enhance feature flag management for RSC portable-stories compatibility.code/renderers/react/src/preset.tsto replace globalFEATURESwith locally scopedfeaturesobject.experimentalRSCfeature flag based on current preset configuration usingoptions.presets.apply('features', {}, options).Thorough testing is recommended to ensure no regressions.