Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add version callout to portable stories docs #28779

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Aug 1, 2024

What I did

See title. Follow-up to #28764.

Checklist for Contributors

Testing

N/A - text-only docs change

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

Greptile Summary

Added version callouts to the documentation for portable stories in Jest and Vitest, specifying the availability of the API from Storybook version 8.2.7 and up.

  • Updated docs/api/portable-stories/portable-stories-jest.mdx to include version callout for Storybook 8.2.7+.
  • Updated docs/api/portable-stories/portable-stories-vitest.mdx to include version callout for Storybook 8.2.7+.

@kylegach kylegach added documentation ci:docs Run the CI jobs for documentation checks only. labels Aug 1, 2024
@kylegach kylegach self-assigned this Aug 1, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Aug 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 56d6496. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kylegach kylegach merged commit 2ebbeed into next Aug 1, 2024
9 of 11 checks passed
@kylegach kylegach deleted the portable-stories-play-to-run-2 branch August 1, 2024 15:42
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant